From: Junio C Hamano <gitster@pobox.com>
To: Steven Drake <sdrake@xnet.co.nz>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add `[decorate]' configuration section.
Date: Thu, 25 Feb 2010 15:12:21 -0800 [thread overview]
Message-ID: <7vk4u0rju2.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: alpine.LNX.2.00.1002261131190.19126@vqena.qenxr.bet.am
Steven Drake <sdrake@xnet.co.nz> writes:
> On Tue, 16 Feb 2010, Junio C Hamano wrote:
> > I was not worried about what your change does. I am worried about
> > protecting what the code after your change currently does from future
> > changes done by other people while you are not actively watching the
> > patches in flight on this list.
>
> But that can easly be with the patch below.
What does that buy us? "future changes" can revert your patch to
builtin-log.c easily.
I was talking about having tests in the test suite; any "future changes"
that breaks the output your series has established would not pass if you
specify what the expected output should be there. Of course they can
change the test pattern in their patches, but then we will immediately
know they are changing the output.
next prev parent reply other threads:[~2010-02-25 23:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-17 8:22 [PATCH] Add `[decorate]' configuration section Steven Drake
2010-02-17 17:50 ` Junio C Hamano
2010-02-17 18:28 ` Re* " Junio C Hamano
2010-02-20 17:17 ` Heiko Voigt
2010-02-20 17:49 ` Thomas Rast
2010-02-22 5:52 ` Junio C Hamano
2010-02-25 22:44 ` Steven Drake
2010-02-25 23:12 ` Junio C Hamano [this message]
2010-02-26 0:06 ` Steven Drake
2010-02-26 3:57 ` Steven Drake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vk4u0rju2.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=sdrake@xnet.co.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).