From: Clemens Buchacher <drizzd@aon.at>
To: Tay Ray Chuan <rctay89@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Mike Hommey <mh@glandium.org>,
"Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH 5/7] http: init and cleanup separately from http-walker
Date: Sun, 21 Feb 2010 11:57:07 +0100 [thread overview]
Message-ID: <20100221105707.GA22534@localhost> (raw)
In-Reply-To: <20100221103820.GA5166@localhost>
On Sun, Feb 21, 2010 at 11:38:20AM +0100, Clemens Buchacher wrote:
> On Sun, Feb 21, 2010 at 11:08:26AM +0800, Tay Ray Chuan wrote:
> > diff --git a/http-fetch.c b/http-fetch.c
> [...]
> > @@ -69,7 +70,8 @@ int main(int argc, const char **argv)
> > url = rewritten_url;
> > }
> >
> > - walker = get_http_walker(url, NULL);
> > + http_init(NULL);
> > + walker = get_http_walker(url);
> > walker->get_tree = get_tree;
> > walker->get_history = get_history;
> > walker->get_all = get_all;
>
> You changed the order of get_http_walker and http_init. But
Umh, actually you didn't. Sorry about that.
>
> add_fill_function(walker, (int (*)(void *)) fill_active_slot);
>
> already deals with curl functionality. So even though I think it technically
> doesn't break, I would prefer if this dependency were still expressed in the
> code.
>
> > @@ -88,6 +90,7 @@ int main(int argc, const char **argv)
> > "status code. Suggest running 'git fsck'.\n");
> > }
> >
> > + http_cleanup();
> > walker_free(walker);
> >
> > free(rewritten_url);
>
> Same as above.
But I think this is still valid.
Clemens
next prev parent reply other threads:[~2010-02-21 10:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-21 3:08 [PATCH 0/7] http: minor improvements Tay Ray Chuan
2010-02-21 3:08 ` [PATCH 1/7] t5541-http-push: check that ref is unchanged for non-ff test Tay Ray Chuan
2010-02-21 3:08 ` [PATCH 2/7] t554[01]-http-push: refactor, add non-ff tests Tay Ray Chuan
2010-02-21 3:08 ` [PATCH 3/7] http-push: remove useless condition Tay Ray Chuan
2010-02-21 10:40 ` Clemens Buchacher
2010-02-21 15:23 ` Tay Ray Chuan
2010-02-21 3:08 ` [PATCH 4/7] http-walker: cleanup more thoroughly Tay Ray Chuan
2010-02-21 3:08 ` [PATCH 5/7] http: init and cleanup separately from http-walker Tay Ray Chuan
2010-02-21 10:38 ` Clemens Buchacher
2010-02-21 10:57 ` Clemens Buchacher [this message]
2010-02-21 15:23 ` Tay Ray Chuan
2010-02-21 3:08 ` [PATCH 6/7] remote-curl: use http_fetch_ref() instead of walker wrapper Tay Ray Chuan
2010-02-21 3:08 ` [PATCH 7/7] remote-curl: init walker only when needed Tay Ray Chuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100221105707.GA22534@localhost \
--to=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=mh@glandium.org \
--cc=rctay89@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).