git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tay Ray Chuan <rctay89@gmail.com>
To: Clemens Buchacher <drizzd@aon.at>
Cc: Git Mailing List <git@vger.kernel.org>,
	Mike Hommey <mh@glandium.org>,
	"Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH 3/7] http-push: remove useless condition
Date: Sun, 21 Feb 2010 23:23:23 +0800	[thread overview]
Message-ID: <be6fef0d1002210723t2cb55460n4dcc1d27ebef03fd@mail.gmail.com> (raw)
In-Reply-To: <20100221104015.GB5166@localhost>

Hi,

On Sun, Feb 21, 2010 at 6:40 PM, Clemens Buchacher <drizzd@aon.at> wrote:
> On Sun, Feb 21, 2010 at 11:08:24AM +0800, Tay Ray Chuan wrote:
>> -                     if (push_verbosely || 1)
>> +                     if (push_verbosely)
>>                               fprintf(stderr, "'%s': up-to-date\n", ref->name);
>
> Just a minor nit-pick. If you end up doing a resend, maybe you could change
> the commit message to this one, since you're actually adding a condition
> that was previously disabled, not removing it.

yes, that makes sense..

-- 
Cheers,
Ray Chuan

  reply	other threads:[~2010-02-21 15:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-21  3:08 [PATCH 0/7] http: minor improvements Tay Ray Chuan
2010-02-21  3:08 ` [PATCH 1/7] t5541-http-push: check that ref is unchanged for non-ff test Tay Ray Chuan
2010-02-21  3:08 ` [PATCH 2/7] t554[01]-http-push: refactor, add non-ff tests Tay Ray Chuan
2010-02-21  3:08 ` [PATCH 3/7] http-push: remove useless condition Tay Ray Chuan
2010-02-21 10:40   ` Clemens Buchacher
2010-02-21 15:23     ` Tay Ray Chuan [this message]
2010-02-21  3:08 ` [PATCH 4/7] http-walker: cleanup more thoroughly Tay Ray Chuan
2010-02-21  3:08 ` [PATCH 5/7] http: init and cleanup separately from http-walker Tay Ray Chuan
2010-02-21 10:38   ` Clemens Buchacher
2010-02-21 10:57     ` Clemens Buchacher
2010-02-21 15:23       ` Tay Ray Chuan
2010-02-21  3:08 ` [PATCH 6/7] remote-curl: use http_fetch_ref() instead of walker wrapper Tay Ray Chuan
2010-02-21  3:08 ` [PATCH 7/7] remote-curl: init walker only when needed Tay Ray Chuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be6fef0d1002210723t2cb55460n4dcc1d27ebef03fd@mail.gmail.com \
    --to=rctay89@gmail.com \
    --cc=drizzd@aon.at \
    --cc=git@vger.kernel.org \
    --cc=mh@glandium.org \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).