From: Aaron Schrab <aaron@schrab.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Phil Hord" <phil.hord@gmail.com>,
"SZEDER Gábor" <szeder@ira.uka.de>,
git@vger.kernel.org, "Fredrik Gustafsson" <iveqy@iveqy.com>,
"Federico Lucifredi" <federico@canonical.com>
Subject: Re: Git Bug report
Date: Thu, 6 Oct 2011 18:57:40 -0400 [thread overview]
Message-ID: <20111006225740.GG24640@pug.qqx.org> (raw)
In-Reply-To: <7vy5wy145q.fsf@alter.siamese.dyndns.org>
At 09:22 -0700 06 Oct 2011, Junio C Hamano <gitster@pobox.com> wrote:
>Yeah, after thinking about it a bit more, whenever we see ".git" during
>the upward discovery process, we should always warn if we know it is _not_
>a GIT_DIR before looking for another ".git" at higher levels, as anything
>in that directory cannot be added. If we cannot tell if it is or is not
>a GIT_DIR, we should error out---the reason we cannot tell most likely is
>because we cannot read it, and such a file, if it is not a GIT_DIR, cannot
>be tracked in the real GIT_DIR at a higher level, and if it is a GIT_DIR,
>we cannot use it to record updates or inspect existing history.
Yes, I think that sounds like a good idea. That should also solve a
related problem that I noticed while checking out the current behaviour.
Currently if the .git directory of a submodule is inaccessible running
`git status` from anywhere in the parent repository (including within
the submodule) will cause git to recursively call itself until enough
resources are used to prevent further forking. I then tried this with
the patch from earlier in the thread applied, but with the call to
error() changed to call die() instead. With that change it quickly
failed with a useful error message.
next prev parent reply other threads:[~2011-10-06 23:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-04 21:24 Git Bug report Federico Lucifredi
2011-10-05 6:11 ` Johannes Sixt
2011-10-05 8:17 ` [PATCH] Report errors related to .git access during repository discovery Nguyễn Thái Ngọc Duy
2011-10-05 18:32 ` Git Bug report Federico Lucifredi
2011-10-05 7:22 ` Fredrik Gustafsson
2011-10-05 16:49 ` Junio C Hamano
2011-10-05 21:56 ` Nguyen Thai Ngoc Duy
2011-10-06 0:33 ` SZEDER Gábor
2011-10-06 0:44 ` Junio C Hamano
2011-10-06 1:09 ` SZEDER Gábor
[not found] ` <CABURp0qCsKG2oOxLw4BfU8UM=9V+pigd69ZK=TZVwetBPqjuiA@mail.gmail.com>
2011-10-06 16:22 ` Junio C Hamano
2011-10-06 16:26 ` Matthieu Moy
2011-10-06 16:54 ` Phil Hord
2011-10-06 22:57 ` Aaron Schrab [this message]
2011-10-06 16:48 ` Phil Hord
2022-04-14 7:22 Git Bug Report Randall Alfaro
2022-10-10 23:09 Git bug report Camden Narzt
2023-08-04 16:46 git " Paul Watson
2023-08-04 17:28 ` rsbecker
2023-08-08 17:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111006225740.GG24640@pug.qqx.org \
--to=aaron@schrab.com \
--cc=federico@canonical.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=iveqy@iveqy.com \
--cc=phil.hord@gmail.com \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).