From: Phil Hord <phil.hord@gmail.com>
To: "SZEDER Gábor" <szeder@ira.uka.de>
Cc: Junio C Hamano <gitster@pobox.com>,
Fredrik Gustafsson <iveqy@iveqy.com>,
Federico Lucifredi <federico@canonical.com>,
git@vger.kernel.org
Subject: Re: Git Bug report
Date: Thu, 6 Oct 2011 12:48:14 -0400 [thread overview]
Message-ID: <CABURp0qw55bKNEjAnn5UHc5nPqiF4MEyG4SmHZf3qJEDFaug2g@mail.gmail.com> (raw)
In-Reply-To: <20111006010940.GR2208@goldbirke>
On 10/5/11, SZEDER Gábor <szeder@ira.uka.de> wrote:
> On Wed, Oct 05, 2011 at 05:44:54PM -0700, Junio C Hamano wrote:
>> SZEDER Gábor <szeder@ira.uka.de> writes:
>>
>> > And what about unreadable .git files?
>>
>> Having then inside a working tree is so sick that I do not think it
>> deserves consideration.
>
> I'm not sure why is this any different than having a .git directory
> that is not a repository inside a working tree.
What should happen here? Ignore it and keep searching? Or fail?
I just added some common gitfile detection code and I noticed that the
oddball case now is the one that dies on error rather than continuing
to search for alternate explanations. I left the oddball behavior
assuming it is desireable, but now you have me rethinking it.
Phil
next prev parent reply other threads:[~2011-10-06 16:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-04 21:24 Git Bug report Federico Lucifredi
2011-10-05 6:11 ` Johannes Sixt
2011-10-05 8:17 ` [PATCH] Report errors related to .git access during repository discovery Nguyễn Thái Ngọc Duy
2011-10-05 18:32 ` Git Bug report Federico Lucifredi
2011-10-05 7:22 ` Fredrik Gustafsson
2011-10-05 16:49 ` Junio C Hamano
2011-10-05 21:56 ` Nguyen Thai Ngoc Duy
2011-10-06 0:33 ` SZEDER Gábor
2011-10-06 0:44 ` Junio C Hamano
2011-10-06 1:09 ` SZEDER Gábor
[not found] ` <CABURp0qCsKG2oOxLw4BfU8UM=9V+pigd69ZK=TZVwetBPqjuiA@mail.gmail.com>
2011-10-06 16:22 ` Junio C Hamano
2011-10-06 16:26 ` Matthieu Moy
2011-10-06 16:54 ` Phil Hord
2011-10-06 22:57 ` Aaron Schrab
2011-10-06 16:48 ` Phil Hord [this message]
2022-04-14 7:22 Git Bug Report Randall Alfaro
2022-10-10 23:09 Git bug report Camden Narzt
2023-08-04 16:46 git " Paul Watson
2023-08-04 17:28 ` rsbecker
2023-08-08 17:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABURp0qw55bKNEjAnn5UHc5nPqiF4MEyG4SmHZf3qJEDFaug2g@mail.gmail.com \
--to=phil.hord@gmail.com \
--cc=federico@canonical.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=iveqy@iveqy.com \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).