[PATCH/RFC] git-svn: use path accessor for Git::SVN objects

[PATCH/RFC] git-svn: use path accessor for Git::SVN objects

[Eric Wong]

The accessors should improve maintainability and enforce
consistent access to Git::SVN objects.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
  (RFC since I could've missed something)

  Eric Wong <normalperson@yhbt.net> wrote:
  > I'll apply the following (on top of a patch which fixes some
  > {path} usages):

 git-svn.perl       | 2 +-
 perl/Git/SVN/Ra.pm | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/git-svn.perl b/git-svn.perl
index 0d77ffb..bd5266c 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -1314,7 +1314,7 @@ sub get_svnprops {
 	$path = $cmd_dir_prefix . $path;
 	fatal("No such file or directory: $path") unless -e $path;
 	my $is_dir = -d $path ? 1 : 0;
-	$path = join_paths($gs->{path}, $path);
+	$path = join_paths($gs->path, $path);
 
 	# canonicalize the path (otherwise libsvn will abort or fail to
 	# find the file)
diff --git a/perl/Git/SVN/Ra.pm b/perl/Git/SVN/Ra.pm
index 90ec30b..049c97b 100644
--- a/perl/Git/SVN/Ra.pm
+++ b/perl/Git/SVN/Ra.pm
@@ -416,7 +416,7 @@ sub gs_fetch_loop_common {
 		}
 		$SVN::Error::handler = $err_handler;
 
-		my %exists = map { $_->{path} => $_ } @$gsv;
+		my %exists = map { $_->path => $_ } @$gsv;
 		foreach my $r (sort {$a <=> $b} keys %revs) {
 			my ($paths, $logged) = @{$revs{$r}};
 
-- 
1.7.12.441.g0590587.dirty

Re: [PATCH/RFC] git-svn: use path accessor for Git::SVN objects

[Jonathan Nieder]

Eric Wong wrote:

> The accessors should improve maintainability and enforce
> consistent access to Git::SVN objects.
>
> Signed-off-by: Eric Wong <normalperson@yhbt.net>
> ---
>   (RFC since I could've missed something)
[...]
>  git-svn.perl       | 2 +-
>  perl/Git/SVN/Ra.pm | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

I think that's all of them, so for what it's worth,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Re: [PATCH/RFC] git-svn: use path accessor for Git::SVN objects

[Junio C Hamano]

Jonathan Nieder <jrnieder@gmail.com> writes:

> Eric Wong wrote:
>
>> The accessors should improve maintainability and enforce
>> consistent access to Git::SVN objects.
>>
>> Signed-off-by: Eric Wong <normalperson@yhbt.net>
>> ---
>>   (RFC since I could've missed something)
> [...]
>>  git-svn.perl       | 2 +-
>>  perl/Git/SVN/Ra.pm | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> I think that's all of them, so for what it's worth,
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks for helping to move things forward.