From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Sixt <j.sixt@viscovery.net>, git@vger.kernel.org
Subject: Re: [PATCH 0/4] drop some "int x = x" hacks to silence gcc warnings
Date: Fri, 22 Mar 2013 12:18:37 -0400 [thread overview]
Message-ID: <20130322161837.GG3083@sigill.intra.peff.net> (raw)
In-Reply-To: <20130321154402.GA25907@sigill.intra.peff.net>
On Thu, Mar 21, 2013 at 11:44:02AM -0400, Jeff King wrote:
> > I am for dropping "= x" and leaving it uninitialized at the
> > declaration site, or explicitly initializing it to some
> > reasonable starting value (e.g. NULL if it is a pointer) and
> > adding a comment to say that the initialization is to squelch
> > compiler warnings.
>
> I'd be in favor of that, too. In many cases, I think the fact that gcc
> cannot trace the control flow is a good indication that it is hard for a
> human to trace it, too. And in those cases we would be better off
> restructuring the code slightly to make it more obvious to both types of
> readers.
>
> Two patches to follow.
>
> [5/4]: fast-import: clarify "inline" logic in file_change_m
> [6/4]: run-command: always set failed_errno in start_command
And here are two more; with these, our code base should be free of "x =
x" initializations (at least according to clang).
[7/4]: submodule: clarify logic in show_submodule_summary
[8/4]: match-trees: drop "x = x" initializations
Not pressing, obviously, but since I had just analyzed the code
yesterday, I wanted to do it while they were still fresh in my mind.
-Peff
next prev parent reply other threads:[~2013-03-22 16:19 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 11:03 [PATCH 0/4] drop some "int x = x" hacks to silence gcc warnings Jeff King
2013-03-21 11:05 ` [PATCH 1/4] wt-status: fix possible use of uninitialized variable Jeff King
2013-03-21 19:49 ` Jonathan Nieder
2013-03-21 19:55 ` Junio C Hamano
2013-03-21 19:58 ` Jonathan Nieder
2013-03-22 16:15 ` Jeff King
2013-03-21 11:08 ` [PATCH 2/4] fast-import: use pointer-to-pointer to keep list tail Jeff King
2013-03-21 20:43 ` Jonathan Nieder
2013-03-21 11:10 ` [PATCH 3/4] drop some obsolete "x = x" compiler warning hacks Jeff King
2013-03-21 15:16 ` Erik Faye-Lund
2013-03-21 20:47 ` Jonathan Nieder
2013-03-24 7:17 ` Torsten Bögershausen
2013-03-21 11:13 ` [PATCH 4/4] transport: drop "int cmp = cmp" hack Jeff King
2013-03-21 20:59 ` Jonathan Nieder
2013-03-24 4:00 ` Junio C Hamano
2013-03-24 9:32 ` Jeff King
2013-03-24 14:54 ` Torsten Bögershausen
2013-03-25 19:50 ` Junio C Hamano
2013-03-25 21:06 ` Jeff King
2013-03-25 21:55 ` Junio C Hamano
2013-03-21 11:45 ` [PATCH 0/4] drop some "int x = x" hacks to silence gcc warnings Johannes Sixt
2013-03-21 11:55 ` Jeff King
2013-03-21 14:58 ` Junio C Hamano
2013-03-21 15:19 ` Junio C Hamano
2013-03-21 15:44 ` Jeff King
2013-03-21 15:44 ` [PATCH 5/4] fast-import: clarify "inline" logic in file_change_m Jeff King
2013-03-21 15:45 ` [PATCH 6/4] run-command: always set failed_errno in start_command Jeff King
2013-03-21 21:02 ` [PATCH 0/4] drop some "int x = x" hacks to silence gcc warnings Jonathan Nieder
2013-03-22 16:18 ` Jeff King [this message]
2013-03-22 16:19 ` [PATCH 7/4] submodule: clarify logic in show_submodule_summary Jeff King
2013-03-22 21:10 ` Junio C Hamano
2013-03-22 16:21 ` [PATCH 8/4] match-trees: drop "x = x" initializations Jeff King
2013-03-22 21:26 ` Junio C Hamano
2013-03-22 21:33 ` Junio C Hamano
2013-03-22 21:36 ` Jeff King
2013-03-23 18:57 ` René Scharfe
2013-03-24 4:55 ` Junio C Hamano
2013-03-24 10:01 ` Jeff King
2013-03-24 22:46 ` René Scharfe
2013-03-25 16:10 ` Junio C Hamano
2013-03-21 13:44 ` [PATCH 0/4] drop some "int x = x" hacks to silence gcc warnings Joachim Schmitz
2013-03-21 13:56 ` Joachim Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130322161837.GG3083@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).