From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
Cc: Jeff King <peff@peff.net>, Johannes Sixt <j.sixt@viscovery.net>,
git@vger.kernel.org
Subject: Re: [PATCH 8/4] match-trees: drop "x = x" initializations
Date: Sat, 23 Mar 2013 21:55:53 -0700 [thread overview]
Message-ID: <7vli9d4crq.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <514DFB1A.8040102@lsrfire.ath.cx> (=?utf-8?Q?=22Ren=C3=A9?= Scharfe"'s message of "Sat, 23 Mar 2013 19:57:30 +0100")
René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
> Hmm, let's see if we can help the compiler follow the code without
> making it harder for people to understand. The patch looks a bit
> jumbled, but the resulting code is OK in my biased opinion.
I actually think the result is much better than a mere "OK"; the
duplicated "at this point we know path1 (or path2) is missing from
the other side" has been bothering me and I was about to suggest a
similar rewrite before I read your message ;-)
However, the same compiler still thinks {elem,path,mode}1 can be
used uninitialized (but not {elem,path,mode}2). The craziness I
reported in the previous message is also the same. With this patch
on top to swap the side we inspect first, the compiler thinks
{elem,path,mode}2 can be used uninitialized but not the other three
variables X-<.
So I like your change for readability, but for GCC 4.4.5 we still
need the unnecessary initialization.
match-trees.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/match-trees.c b/match-trees.c
index c0c66bb..9ea2c80 100644
--- a/match-trees.c
+++ b/match-trees.c
@@ -77,16 +77,16 @@ static int score_trees(const unsigned char *hash1, const unsigned char *hash2)
unsigned mode1, mode2;
int cmp = 0;
- if (one.size)
- elem1 = tree_entry_extract(&one, &path1, &mode1);
- else
- /* two has more entries */
- cmp = 1;
if (two.size)
elem2 = tree_entry_extract(&two, &path2, &mode2);
else
/* two lacks this entry */
cmp = -1;
+ if (one.size)
+ elem1 = tree_entry_extract(&one, &path1, &mode1);
+ else
+ /* two has more entries */
+ cmp = 1;
if (!cmp)
cmp = base_name_compare(path1, strlen(path1), mode1,
next prev parent reply other threads:[~2013-03-24 4:56 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 11:03 [PATCH 0/4] drop some "int x = x" hacks to silence gcc warnings Jeff King
2013-03-21 11:05 ` [PATCH 1/4] wt-status: fix possible use of uninitialized variable Jeff King
2013-03-21 19:49 ` Jonathan Nieder
2013-03-21 19:55 ` Junio C Hamano
2013-03-21 19:58 ` Jonathan Nieder
2013-03-22 16:15 ` Jeff King
2013-03-21 11:08 ` [PATCH 2/4] fast-import: use pointer-to-pointer to keep list tail Jeff King
2013-03-21 20:43 ` Jonathan Nieder
2013-03-21 11:10 ` [PATCH 3/4] drop some obsolete "x = x" compiler warning hacks Jeff King
2013-03-21 15:16 ` Erik Faye-Lund
2013-03-21 20:47 ` Jonathan Nieder
2013-03-24 7:17 ` Torsten Bögershausen
2013-03-21 11:13 ` [PATCH 4/4] transport: drop "int cmp = cmp" hack Jeff King
2013-03-21 20:59 ` Jonathan Nieder
2013-03-24 4:00 ` Junio C Hamano
2013-03-24 9:32 ` Jeff King
2013-03-24 14:54 ` Torsten Bögershausen
2013-03-25 19:50 ` Junio C Hamano
2013-03-25 21:06 ` Jeff King
2013-03-25 21:55 ` Junio C Hamano
2013-03-21 11:45 ` [PATCH 0/4] drop some "int x = x" hacks to silence gcc warnings Johannes Sixt
2013-03-21 11:55 ` Jeff King
2013-03-21 14:58 ` Junio C Hamano
2013-03-21 15:19 ` Junio C Hamano
2013-03-21 15:44 ` Jeff King
2013-03-21 15:44 ` [PATCH 5/4] fast-import: clarify "inline" logic in file_change_m Jeff King
2013-03-21 15:45 ` [PATCH 6/4] run-command: always set failed_errno in start_command Jeff King
2013-03-21 21:02 ` [PATCH 0/4] drop some "int x = x" hacks to silence gcc warnings Jonathan Nieder
2013-03-22 16:18 ` Jeff King
2013-03-22 16:19 ` [PATCH 7/4] submodule: clarify logic in show_submodule_summary Jeff King
2013-03-22 21:10 ` Junio C Hamano
2013-03-22 16:21 ` [PATCH 8/4] match-trees: drop "x = x" initializations Jeff King
2013-03-22 21:26 ` Junio C Hamano
2013-03-22 21:33 ` Junio C Hamano
2013-03-22 21:36 ` Jeff King
2013-03-23 18:57 ` René Scharfe
2013-03-24 4:55 ` Junio C Hamano [this message]
2013-03-24 10:01 ` Jeff King
2013-03-24 22:46 ` René Scharfe
2013-03-25 16:10 ` Junio C Hamano
2013-03-21 13:44 ` [PATCH 0/4] drop some "int x = x" hacks to silence gcc warnings Joachim Schmitz
2013-03-21 13:56 ` Joachim Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vli9d4crq.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=peff@peff.net \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).