git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brandon Williams <bmwill@google.com>
To: Jeff King <peff@peff.net>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
	git@vger.kernel.org, gitster@pobox.com
Subject: Re: [RFC 0/2] grep: make output consistent with revision syntax
Date: Thu, 19 Jan 2017 10:26:33 -0800	[thread overview]
Message-ID: <20170119182633.GG10641@google.com> (raw)
In-Reply-To: <20170119165958.xtotlvdta7udqllb@sigill.intra.peff.net>

On 01/19, Jeff King wrote:
> On Thu, Jan 19, 2017 at 03:03:45PM +0000, Stefan Hajnoczi wrote:
> 
> > git-grep(1)'s output is not consistent with git-rev-parse(1) revision syntax.
> > 
> > This means you cannot take "rev:path/to/file.c: foo();" output from git-grep(1)
> > and expect "git show rev:path/to/file.c" to work.  See the individual patches
> > for examples of command-lines that produce invalid output.
> 
> I think this is a good goal.

I agree.

> I couldn't immediately think of any cases where your patches would
> misbehave, but my initial thought was that the "/" versus ":"
> distinction is about whether the initial object is a tree or a commit.

I think this is also the case, I couldn't think of another case where
this decision wasn't based on if the object is a tree or a commit.
Interestingly enough I don't think we have any tests that exist that
test the formatting of grep's output when given a tree object since the
test suite still passes with these changes in. Which means this fix
should probably include a couple tests to ensure there's no regression
in the future.

-- 
Brandon Williams

  reply	other threads:[~2017-01-19 18:26 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-19 15:03 [RFC 0/2] grep: make output consistent with revision syntax Stefan Hajnoczi
2017-01-19 15:03 ` [RFC 1/2] grep: only add delimiter if there isn't one already Stefan Hajnoczi
2017-01-19 18:39   ` Junio C Hamano
2017-01-20 13:56     ` Stefan Hajnoczi
2017-01-20 18:16       ` Junio C Hamano
2017-01-23 13:15         ` Stefan Hajnoczi
2017-01-24 19:07           ` Jakub Narębski
2017-01-24 20:48             ` Philip Oakley
2017-01-19 15:03 ` [RFC 2/2] grep: use '/' delimiter for paths Stefan Hajnoczi
2017-01-19 18:29   ` Brandon Williams
2017-01-20 14:17     ` Stefan Hajnoczi
2017-01-19 18:54   ` Junio C Hamano
2017-01-20 14:12     ` Stefan Hajnoczi
2017-01-20 14:19       ` Jeff King
2017-01-20 22:56         ` Junio C Hamano
2017-01-23 13:29           ` Stefan Hajnoczi
2017-01-24 17:18             ` Phil Hord
2017-01-19 16:59 ` [RFC 0/2] grep: make output consistent with revision syntax Jeff King
2017-01-19 18:26   ` Brandon Williams [this message]
2017-01-20 14:18   ` Stefan Hajnoczi
2017-01-20 14:32     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170119182633.GG10641@google.com \
    --to=bmwill@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).