From: Jeff King <peff@peff.net>
To: Nicolas Morey-Chaisemartin <nicolas@morey-chaisemartin.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC 0/3] imap-send curl tunnelling support
Date: Wed, 16 Aug 2017 04:34:32 -0400 [thread overview]
Message-ID: <20170816083432.rgurgckch6phcul3@sigill.intra.peff.net> (raw)
In-Reply-To: <ab866314-608b-eaca-b335-12cffe165526@morey-chaisemartin.com>
On Wed, Aug 09, 2017 at 04:43:26PM +0200, Nicolas Morey-Chaisemartin wrote:
> I have a few doubt on patch #2:
> - is socketpair working on all git supported system (windows ?)
I'm pretty sure the answer is no, after searching a bit for mingw and
socketpair. The big question is whether we could come up with a suitable
replacement. And that would depend on how libcurl works on Windows, I
think (because it's going to feed whatever we give it to other syscall
wrappers).
> - should socketpair always be used or limited to the curl over tunnel case ?
> I don't think there is too much different between an unname pipe and a socketpair but I'm not sure either :)
There's not much difference in practice. The obvious one is that
half-duplex shutdowns require shutdown() on a socket and just close() on
the write half of a pipe. I don't know if we do that or not.
I'd be inclined to leave the existing code alone, though, just because
of the risk of regression (and because I don't think the curl and
non-curl versions actually share that much code). But I haven't looked
deeply, so I may be wrong.
> It appears curl do not support the PREAUTH tag.
Too bad. IMHO preauth is the main reason to use a tunnel in the first
place.
-Peff
next prev parent reply other threads:[~2017-08-16 8:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 14:43 [RFC 0/3] imap-send curl tunnelling support Nicolas Morey-Chaisemartin
2017-08-09 14:46 ` [RFC 1/3] imap-send: move tunnel setup to its own function Nicolas Morey-Chaisemartin
2017-08-09 14:46 ` [RFC 2/3] imap-send: use a socketpair instead of pipe to communicate with the tunnel Nicolas Morey-Chaisemartin
2017-08-09 14:46 ` [RFC 3/3] imap_send: add support for curl over tunnel Nicolas Morey-Chaisemartin
2017-08-15 17:49 ` [RFC 0/3] imap-send curl tunnelling support Nicolas Morey-Chaisemartin
2017-08-15 18:18 ` Stefan Beller
2017-08-16 12:30 ` Johannes Schindelin
2017-08-21 7:27 ` Nicolas Morey-Chaisemartin
2017-08-22 17:10 ` Johannes Sixt
2017-08-22 18:22 ` Nicolas Morey-Chaisemartin
2017-08-23 22:35 ` Johannes Schindelin
2017-08-16 8:34 ` Jeff King [this message]
2017-08-21 7:34 ` Nicolas Morey-Chaisemartin
2017-08-23 21:43 ` Jeff King
2017-08-24 8:00 ` Nicolas Morey-Chaisemartin
2017-08-24 13:53 ` Jeff King
2017-08-24 14:02 ` Daniel Stenberg
2017-08-24 14:30 ` Jeff King
2017-08-24 21:22 ` Daniel Stenberg
2017-08-24 14:15 ` Nicolas Morey-Chaisemartin
2017-08-24 14:28 ` Jeff King
[not found] ` <7ee8331d-e154-7539-e000-4087406f39fa@suse.de>
2017-08-16 8:39 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170816083432.rgurgckch6phcul3@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=nicolas@morey-chaisemartin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).