git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas Morey-Chaisemartin <nicolas@morey-chaisemartin.com>
To: <git@vger.kernel.org>
Cc: <peff@peff.net>
Subject: [RFC 2/3] imap-send: use a socketpair instead of pipe to communicate with the tunnel
Date: Wed, 9 Aug 2017 16:46:15 +0200	[thread overview]
Message-ID: <ac79ae33-db5a-ae90-5e6d-b6364c77266a@morey-chaisemartin.com> (raw)
In-Reply-To: <ab866314-608b-eaca-b335-12cffe165526@morey-chaisemartin.com>

Signed-off-by: Nicolas Morey-Chaisemartin <nicolas@morey-chaisemartin.com>
---
 imap-send.c | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/imap-send.c b/imap-send.c
index 10f668eb7..e5ff70096 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -929,18 +929,27 @@ static int auth_cram_md5(struct imap_store *ctx, struct imap_cmd *cmd, const cha
 static void setup_tunnel(struct imap_server_conf *srvc, int fds[2])
 {
 	struct child_process tunnel = CHILD_PROCESS_INIT;
+	int sock_fds[2];
 
 	imap_info("Starting tunnel '%s'... ", srvc->tunnel);
 
+	if (socketpair(AF_UNIX, SOCK_STREAM, 0, sock_fds))
+		die("failed to create socketpair for proxy");
+
 	argv_array_push(&tunnel.args, srvc->tunnel);
 	tunnel.use_shell = 1;
-	tunnel.in = -1;
-	tunnel.out = -1;
+	tunnel.in = sock_fds[1];
+	/* Duplicate the fd as the child process requires
+	 * 1 for stdin, one for stdout */
+	tunnel.out = dup(sock_fds[1]);
+	if (tunnel.out < 0)
+		die("failed to create fd to proxy");
+
 	if (start_command(&tunnel))
 		die("cannot start proxy %s", srvc->tunnel);
 
-	fds[0] = tunnel.out;
-	fds[1] = tunnel.in;
+	fds[0] = sock_fds[0];
+	fds[1] = sock_fds[0];
 
 	imap_info("ok\n");
 
-- 
2.14.0.3.gb4ff627ec.dirty



  parent reply	other threads:[~2017-08-09 14:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-09 14:43 [RFC 0/3] imap-send curl tunnelling support Nicolas Morey-Chaisemartin
2017-08-09 14:46 ` [RFC 1/3] imap-send: move tunnel setup to its own function Nicolas Morey-Chaisemartin
2017-08-09 14:46 ` Nicolas Morey-Chaisemartin [this message]
2017-08-09 14:46 ` [RFC 3/3] imap_send: add support for curl over tunnel Nicolas Morey-Chaisemartin
2017-08-15 17:49 ` [RFC 0/3] imap-send curl tunnelling support Nicolas Morey-Chaisemartin
2017-08-15 18:18   ` Stefan Beller
2017-08-16 12:30     ` Johannes Schindelin
2017-08-21  7:27       ` Nicolas Morey-Chaisemartin
2017-08-22 17:10         ` Johannes Sixt
2017-08-22 18:22           ` Nicolas Morey-Chaisemartin
2017-08-23 22:35           ` Johannes Schindelin
2017-08-16  8:34 ` Jeff King
2017-08-21  7:34   ` Nicolas Morey-Chaisemartin
2017-08-23 21:43     ` Jeff King
2017-08-24  8:00       ` Nicolas Morey-Chaisemartin
2017-08-24 13:53         ` Jeff King
2017-08-24 14:02           ` Daniel Stenberg
2017-08-24 14:30             ` Jeff King
2017-08-24 21:22               ` Daniel Stenberg
2017-08-24 14:15           ` Nicolas Morey-Chaisemartin
2017-08-24 14:28             ` Jeff King
     [not found] ` <7ee8331d-e154-7539-e000-4087406f39fa@suse.de>
2017-08-16  8:39   ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac79ae33-db5a-ae90-5e6d-b6364c77266a@morey-chaisemartin.com \
    --to=nicolas@morey-chaisemartin.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).