git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Dorian Taylor <dorian.taylor.lists@gmail.com>
Cc: Jeff King <peff@peff.net>,
	git@vger.kernel.org, Brandon Williams <bmwill@google.com>
Subject: Re: bug in HTTP protocol spec
Date: Wed, 21 Feb 2018 21:37:22 -0800	[thread overview]
Message-ID: <20180222053722.GB133592@aiede.svl.corp.google.com> (raw)
In-Reply-To: <89E9DF80-F811-4F7A-AA35-0F52F1180BAF@gmail.com>

(+cc: bmwill@, who is working on protocol v2)
Hi,

Dorian Taylor wrote:
> On Feb 21, 2018, at 2:15 PM, Jeff King <peff@peff.net> wrote:

>> Thanks, I agree the document is buggy. Do you want to submit a patch?
>
> Will this do?

Thanks for writing it.

Do you mind if we forge your sign-off?  (See Documentation/SubmittingPatches
item '(5) Certify your work' for details about what this means.)

> Note I am not sure what the story is behind that `version 1`
> element, whether it's supposed to go before or after the null packet
> or if there should be another null packet or what. Perhaps somebody
> more fluent with the smart protocol can advise.

I believe the 'version 1' goes after the flush-packet.

Thanks,
Jonathan

  reply	other threads:[~2018-02-22  5:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-21 18:29 bug in HTTP protocol spec Dorian Taylor
2018-02-21 22:15 ` Jeff King
2018-02-21 23:50   ` Dorian Taylor
2018-02-22  5:37     ` Jonathan Nieder [this message]
2018-02-22  7:23       ` Dorian Taylor
2018-02-22 10:08         ` Jeff King
2018-02-22 16:16           ` Dorian Taylor
2018-02-22 20:02           ` Junio C Hamano
2018-02-22 20:12             ` Dorian Taylor
2018-03-03  5:27               ` [PATCH] smart-http: document flush after "# service" line Jeff King
2018-03-03  8:28                 ` Eric Sunshine
2018-03-03 10:02                   ` Jeff King
2018-02-22 17:52         ` bug in HTTP protocol spec Brandon Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180222053722.GB133592@aiede.svl.corp.google.com \
    --to=jrnieder@gmail.com \
    --cc=bmwill@google.com \
    --cc=dorian.taylor.lists@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).