From: Dorian Taylor <dorian.taylor.lists@gmail.com>
To: git@vger.kernel.org
Subject: bug in HTTP protocol spec
Date: Wed, 21 Feb 2018 10:29:35 -0800 [thread overview]
Message-ID: <4F85B1C3-9B5B-4D7C-8907-B728C18A70CD@gmail.com> (raw)
Hello list,
I had been banging my head all morning trying to figure out why I couldn’t get a little HTTP implementation to clone/push via the smart protocol (just wrapping git-receive-pack/git-upload-pack). I kept getting the following (likely familiar to some) error:
```
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
```
I didn’t get an insight until I ran with GIT_TRACE_PACKET=true on a known-good remote (i.e. GitHub), that the null packet-line `0000` has to follow the service line. This is not reflected in the example here:
https://github.com/git/git/blob/6464679d9620d91b639e2681b9cc6473f3856d09/Documentation/technical/http-protocol.txt#L216
It is also not reflected in the BNF:
https://github.com/git/git/blob/6464679d9620d91b639e2681b9cc6473f3856d09/Documentation/technical/http-protocol.txt#L279
(Note these links are from the most recent commit of this file as of this writing.)
Just thought somebody would like to know.
Regards,
--
Dorian Taylor
Make things. Make sense.
https://doriantaylor.com
next reply other threads:[~2018-02-21 18:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 18:29 Dorian Taylor [this message]
2018-02-21 22:15 ` bug in HTTP protocol spec Jeff King
2018-02-21 23:50 ` Dorian Taylor
2018-02-22 5:37 ` Jonathan Nieder
2018-02-22 7:23 ` Dorian Taylor
2018-02-22 10:08 ` Jeff King
2018-02-22 16:16 ` Dorian Taylor
2018-02-22 20:02 ` Junio C Hamano
2018-02-22 20:12 ` Dorian Taylor
2018-03-03 5:27 ` [PATCH] smart-http: document flush after "# service" line Jeff King
2018-03-03 8:28 ` Eric Sunshine
2018-03-03 10:02 ` Jeff King
2018-02-22 17:52 ` bug in HTTP protocol spec Brandon Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F85B1C3-9B5B-4D7C-8907-B728C18A70CD@gmail.com \
--to=dorian.taylor.lists@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).