git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Kyle Meyer <kyle@kyleam.com>
Cc: git@vger.kernel.org, Johannes.Schindelin@gmx.de
Subject: Re: [PATCH] range-diff: update stale summary of --no-dual-color
Date: Wed, 22 Aug 2018 19:47:19 -0700	[thread overview]
Message-ID: <20180823024719.GG92374@aiede.svl.corp.google.com> (raw)
In-Reply-To: <20180823023955.12980-1-kyle@kyleam.com>

Hi,

Kyle Meyer wrote:

> 275267937b (range-diff: make dual-color the default mode, 2018-08-13)
> replaced --dual-color with --no-dual-color but left the option's
> summary untouched.  Rewrite the summary to describe --no-dual-color
> rather than dual-color.
>
> Signed-off-by: Kyle Meyer <kyle@kyleam.com>
> ---
>  builtin/range-diff.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, good catch!

> diff --git a/builtin/range-diff.c b/builtin/range-diff.c
> index f52d45d9d6..7dc90a5ec3 100644
> --- a/builtin/range-diff.c
> +++ b/builtin/range-diff.c
> @@ -25,7 +25,7 @@ int cmd_range_diff(int argc, const char **argv, const char *prefix)
>  		OPT_INTEGER(0, "creation-factor", &creation_factor,
>  			    N_("Percentage by which creation is weighted")),
>  		OPT_BOOL(0, "no-dual-color", &simple_color,
> -			    N_("color both diff and diff-between-diffs")),
> +			    N_("restrict coloring to outer diff markers")),

What is an outer diff marker?

Thanks,
Jonathan

  reply	other threads:[~2018-08-23  2:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-23  2:39 [PATCH] range-diff: update stale summary of --no-dual-color Kyle Meyer
2018-08-23  2:47 ` Jonathan Nieder [this message]
2018-08-23  3:03   ` Kyle Meyer
2018-08-23  3:22     ` Jonathan Nieder
2018-08-23  4:04       ` Kyle Meyer
2018-08-23  8:27         ` Jonathan Nieder
2018-08-23 12:00           ` [PATCH v2] " Kyle Meyer
2018-08-23 21:10             ` Jonathan Nieder
2018-08-23 21:57               ` [PATCH v3] " Kyle Meyer
2018-08-23 22:02                 ` Jonathan Nieder
2018-08-23 22:08                   ` Junio C Hamano
2018-08-23 22:11                     ` Jonathan Nieder
2018-08-27 17:57                       ` Junio C Hamano
2018-08-23 14:31       ` [PATCH] " Johannes Schindelin
2018-08-23 21:12         ` Jonathan Nieder
2018-08-23 20:54 ` Johannes Schindelin
2018-08-23 21:18   ` Junio C Hamano
2018-08-23 21:27     ` Kyle Meyer
2018-08-23 21:48       ` Junio C Hamano
2018-08-23 21:41     ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180823024719.GG92374@aiede.svl.corp.google.com \
    --to=jrnieder@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=kyle@kyleam.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).