git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Kyle Meyer <kyle@kyleam.com>,
	git@vger.kernel.org, Johannes.Schindelin@gmx.de
Subject: Re: [PATCH v3] range-diff: update stale summary of --no-dual-color
Date: Thu, 23 Aug 2018 15:08:56 -0700	[thread overview]
Message-ID: <xmqqo9dshh1j.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180823220207.GC99542@aiede.svl.corp.google.com> (Jonathan Nieder's message of "Thu, 23 Aug 2018 15:02:07 -0700")

Jonathan Nieder <jrnieder@gmail.com> writes:

> Kyle Meyer wrote:
>
>> 275267937b (range-diff: make dual-color the default mode, 2018-08-13)
>> replaced --dual-color with --no-dual-color but left the option's
>> summary untouched.  Rewrite the summary to describe --no-dual-color
>> rather than dual-color.
>>
>> Helped-by: Jonathan Nieder <jrnieder@gmail.com>
>
> Ha, I don't think I deserve much credit here, but I'll take it. ;-)
>
>> Helped-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
>> Signed-off-by: Kyle Meyer <kyle@kyleam.com>
>> ---
>>  builtin/range-diff.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Sorry, too late.  I'll revert the merge of the previous round out of
'next' and requeue this one, but that will have to wait until the
next integration cycle.

  reply	other threads:[~2018-08-23 22:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-23  2:39 [PATCH] range-diff: update stale summary of --no-dual-color Kyle Meyer
2018-08-23  2:47 ` Jonathan Nieder
2018-08-23  3:03   ` Kyle Meyer
2018-08-23  3:22     ` Jonathan Nieder
2018-08-23  4:04       ` Kyle Meyer
2018-08-23  8:27         ` Jonathan Nieder
2018-08-23 12:00           ` [PATCH v2] " Kyle Meyer
2018-08-23 21:10             ` Jonathan Nieder
2018-08-23 21:57               ` [PATCH v3] " Kyle Meyer
2018-08-23 22:02                 ` Jonathan Nieder
2018-08-23 22:08                   ` Junio C Hamano [this message]
2018-08-23 22:11                     ` Jonathan Nieder
2018-08-27 17:57                       ` Junio C Hamano
2018-08-23 14:31       ` [PATCH] " Johannes Schindelin
2018-08-23 21:12         ` Jonathan Nieder
2018-08-23 20:54 ` Johannes Schindelin
2018-08-23 21:18   ` Junio C Hamano
2018-08-23 21:27     ` Kyle Meyer
2018-08-23 21:48       ` Junio C Hamano
2018-08-23 21:41     ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqo9dshh1j.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=kyle@kyleam.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).