From: Max Kirillov <max@max630.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "Max Kirillov" <max@max630.net>,
"Jelmer Vernooij" <jelmer@jelmer.uk>,
git@vger.kernel.org, "Jeff King" <peff@peff.net>
Subject: [PATCH v2] http-backend test: make empty CONTENT_LENGTH test more realistic
Date: Tue, 11 Sep 2018 23:33:36 +0300
Message-ID: <20180911203336.4601-1-max@max630.net> (raw)
In-Reply-To: <20180911040621.GD20518@aiede.svl.corp.google.com>
This is a test of smart HTTP, so it should use the smart HTTP endpoints
(e.g. /info/refs?service=git-receive-pack), not dumb HTTP (HEAD).
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Max Kirillov <max@max630.net>
---
> do you know why the test passes without 574c513e8d (http-backend: allow empty CONTENT_LENGTH, 2018-09-10)?
Because I did not know what is QUERY_STRING (it is the part after "?"). Fixed now
(Somehow I did see the failure during development. Maybe there was another parameter before?)
I suspect it is not OK in other places of the test, but I hope it should not affect the result
t/t5562-http-backend-content-length.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t5562-http-backend-content-length.sh b/t/t5562-http-backend-content-length.sh
index f94d01f69e..b24d8b05a4 100755
--- a/t/t5562-http-backend-content-length.sh
+++ b/t/t5562-http-backend-content-length.sh
@@ -155,8 +155,8 @@ test_expect_success 'CONTENT_LENGTH overflow ssite_t' '
test_expect_success 'empty CONTENT_LENGTH' '
env \
- QUERY_STRING=/repo.git/HEAD \
- PATH_TRANSLATED="$PWD"/.git/HEAD \
+ QUERY_STRING="service=git-receive-pack" \
+ PATH_TRANSLATED="$PWD"/.git/info/refs \
GIT_HTTP_EXPORT_ALL=TRUE \
REQUEST_METHOD=GET \
CONTENT_LENGTH="" \
--
2.17.0.1185.g782057d875
next prev parent reply index
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 4:06 [PATCH v3] http-backend: allow empty CONTENT_LENGTH Jonathan Nieder
2018-09-11 20:33 ` Max Kirillov [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-09-08 0:19 [PATCH v2] " Jonathan Nieder
2018-09-08 5:35 ` Max Kirillov
2018-09-08 5:42 ` [PATCH v3] " Max Kirillov
2018-09-10 5:17 ` Jonathan Nieder
2018-09-10 20:36 ` Max Kirillov
2018-09-06 6:10 CONTENT_LENGTH can no longer be empty Jonathan Nieder
2018-09-06 19:35 ` [PATCH] http-backend: allow empty CONTENT_LENGTH Max Kirillov
2018-09-06 21:54 ` Junio C Hamano
2018-09-07 3:27 ` Max Kirillov
2018-09-07 3:38 ` Jeff King
2018-09-07 4:20 ` Max Kirillov
2018-09-07 4:59 ` Max Kirillov
2018-09-07 9:49 ` Junio C Hamano
2018-09-08 5:41 ` Max Kirillov
2018-09-09 4:40 ` Max Kirillov
2018-09-06 22:45 ` Jonathan Nieder
2018-09-07 3:36 ` [PATCH v2] " Max Kirillov
2018-09-09 4:10 ` [PATCH v4] " Max Kirillov
2018-09-10 5:25 ` Jonathan Nieder
2018-09-10 13:17 ` Jeff King
2018-09-10 16:37 ` Junio C Hamano
2018-09-10 18:46 ` Jeff King
2018-09-10 20:53 ` [PATCH] http-backend: Treat empty CONTENT_LENGTH as zero Max Kirillov
2018-09-10 21:22 ` Jonathan Nieder
2018-09-11 1:55 ` Jeff King
2018-09-11 2:20 ` Jonathan Nieder
2018-09-11 2:30 ` Jeff King
2018-09-11 1:58 ` Jeff King
2018-09-11 3:42 ` [PATCH] http-backend: treat " Jonathan Nieder
2018-09-11 4:03 ` Jonathan Nieder
2018-09-11 18:15 ` Junio C Hamano
2018-09-11 18:27 ` Junio C Hamano
2018-09-12 5:56 ` Jeff King
2018-09-12 6:26 ` Jonathan Nieder
2018-09-12 16:10 ` Junio C Hamano
2018-09-11 4:18 ` Junio C Hamano
2018-09-11 4:29 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180911203336.4601-1-max@max630.net \
--to=max@max630.net \
--cc=git@vger.kernel.org \
--cc=jelmer@jelmer.uk \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Mailing List Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/git/0 git/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 git git/ https://lore.kernel.org/git \
git@vger.kernel.org
public-inbox-index git
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.git
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git