From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Andreas Gruenbacher <agruenba@redhat.com>, git@vger.kernel.org
Subject: Re: [PATCH] Clear --exclude list after 'git rev-parse --all'
Date: Fri, 26 Oct 2018 03:46:38 -0400 [thread overview]
Message-ID: <20181026074638.GA3119@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqtvl9fv86.fsf@gitster-ct.c.googlers.com>
On Fri, Oct 26, 2018 at 08:43:37AM +0900, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > An easy test is:
> >
> > $ git rev-list --no-walk --exclude='*' --all --all
> > 3289ca716320457af5d2dd550b716282ad22da11
> > ...a bunch of other tip commits...
> >
> > $ git rev-parse --exclude='*' --all --all
> > [no output, but it should print those same tip commits]
>
> I actually was hoping to see a test that contrasts "--all" (which
> lacks the alleged "clear exclude" bug) with another option that does
> have the "clear exclude", both used with rev-parse, i.e.
>
> $ git rev-parse --exclude='*' --glob='*' --glob='*'
> ... all the ref tips ...
> $ git rev-parse --exclude='*' --all --all
> ... ought to be equivalent, but is empty due to the bug ...
>
> would have been a good demonstration that shows what bug we are
> fixing d(and would have been a good test to accompany the patch.
Yeah, I agree that would be fine, too. I think there are two dimensions
in which to look at the problem, like so:
rev-list rev-parse
-------- ---------
--glob clears clears
--all clears does not clear
Testing either the row or the column (or both) works for me. :)
-Peff
next prev parent reply other threads:[~2018-10-26 7:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 19:17 [PATCH] Clear --exclude list after 'git rev-parse --all' Andreas Gruenbacher
2018-10-24 4:35 ` Junio C Hamano
2018-10-24 9:01 ` Andreas Gruenbacher
2018-10-24 9:24 ` Junio C Hamano
2018-10-24 9:49 ` Andreas Gruenbacher
2018-10-25 10:45 ` Jeff King
2018-10-25 23:43 ` Junio C Hamano
2018-10-26 7:46 ` Jeff King [this message]
2018-10-27 7:12 ` Junio C Hamano
2018-10-27 7:20 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181026074638.GA3119@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=agruenba@redhat.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).