From: Junio C Hamano <gitster@pobox.com>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Clear --exclude list after 'git rev-parse --all'
Date: Wed, 24 Oct 2018 13:35:27 +0900 [thread overview]
Message-ID: <xmqqefcgotbk.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20181023191758.15138-1-agruenba@redhat.com> (Andreas Gruenbacher's message of "Tue, 23 Oct 2018 21:17:58 +0200")
Andreas Gruenbacher <agruenba@redhat.com> writes:
> Commit [1] added the --exclude option to revision.c. The --all,
> --branches, --tags, --remotes, and --glob options clear the exclude
> list. Shortly therafter, commit [2] added the same to 'git rev-parse',
> but without clearing the exclude list for the --all option. Fix that.
>
> [1] e7b432c52 ("revision: introduce --exclude=<glob> to tame wildcards", 2013-08-30)
> [2] 9dc01bf06 ("rev-parse: introduce --exclude=<glob> to tame wildcards", 2013-11-01)
>
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
> ---
> builtin/rev-parse.c | 1 +
> 1 file changed, 1 insertion(+)
All other glob options do show_reference with for_each_ref_in() and
then calls clear_ref_exclusion(), and logically the patch makes
sense.
What is the "problem" this patch fixes, though? Is it easy to add a
new test to t/6018-rev-list-glob.sh to demonstrate that "--glob" (or
whatever that clears exclusion list without this patch) works
correctly but "--all" misbehaves without this change?
Thanks.
> diff --git a/builtin/rev-parse.c b/builtin/rev-parse.c
> index 0f09bbbf6..c71e3b104 100644
> --- a/builtin/rev-parse.c
> +++ b/builtin/rev-parse.c
> @@ -764,6 +764,7 @@ int cmd_rev_parse(int argc, const char **argv, const char *prefix)
> }
> if (!strcmp(arg, "--all")) {
> for_each_ref(show_reference, NULL);
> + clear_ref_exclusion(&ref_excludes);
> continue;
> }
> if (skip_prefix(arg, "--disambiguate=", &arg)) {
next prev parent reply other threads:[~2018-10-24 4:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 19:17 [PATCH] Clear --exclude list after 'git rev-parse --all' Andreas Gruenbacher
2018-10-24 4:35 ` Junio C Hamano [this message]
2018-10-24 9:01 ` Andreas Gruenbacher
2018-10-24 9:24 ` Junio C Hamano
2018-10-24 9:49 ` Andreas Gruenbacher
2018-10-25 10:45 ` Jeff King
2018-10-25 23:43 ` Junio C Hamano
2018-10-26 7:46 ` Jeff King
2018-10-27 7:12 ` Junio C Hamano
2018-10-27 7:20 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqefcgotbk.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=agruenba@redhat.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).