git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Jeff King <peff@peff.net>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Duy Nguyen" <pclouds@gmail.com>,
	"Rohit Ashiwal via GitGitGadget" <gitgitgadget@gmail.com>,
	"Git Mailing List" <git@vger.kernel.org>,
	"Junio C Hamano" <gitster@pobox.com>,
	"Rohit Ashiwal" <rohit.ashiwal265@gmail.com>,
	"Matthieu Moy" <git@matthieu-moy.fr>
Subject: Re: Do test-path_is_{file,dir,exists} make sense anymore with -x?
Date: Mon, 4 Mar 2019 15:36:33 +0100	[thread overview]
Message-ID: <20190304143633.GC28939@szeder.dev> (raw)
In-Reply-To: <20190226210101.GA27914@sigill.intra.peff.net>

On Tue, Feb 26, 2019 at 04:01:01PM -0500, Jeff King wrote:
> > +	{ set +x ; } 2>/dev/null 4>/dev/null
> 
> Ah, this is the magic. Doing:
> 
>   set +x 2>/dev/null
> 
> will still show it, but doing the redirection in a wrapping block means
> that it is applied before the command inside the block is run. Clever.

Yeah, clever, but unfortunately (and to me suprisingly) unportable:

  $ ksh
  $ set -x
  $ echo foo
  + echo foo
  foo
  $ set +x
  $ 

It doesn't show 'set +x', how convenient! :)
However:

  $ set -x
  $ echo foo 2>/dev/null
  + echo foo
  + 2> /dev/null
  foo
  $ { set +x; } 2>/dev/null
  + 2> /dev/null
  $ 

Apparently ksh, ksh93 and mksh show not only the executed commands
but any redirections as well.  It's already visible when running our
tests with ksh and '-x':

  $ ksh ./t9999-test.sh -x
  Initialized empty Git repository in /home/szeder/src/git/t/trash directory.t9999-test/.git/
  expecting success: 
          true
  
  + true
  + 2> /dev/null ok 1 - first
  
  # passed all 1 test(s)
  1..1

NetBSD's sh:

  # set -x
  # echo foo
  + echo foo
  foo
  # echo foo 2>/dev/null
  + echo foo 2>/dev/null
  foo
  # { set +x; } 2>/dev/null
  + using redirections: 2>/dev/null do



  parent reply	other threads:[~2019-03-04 14:36 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-26 13:42 [PATCH 0/1] [GSoC][PATCH] tests: replace test -(d|f) with test_path_is_(dir|file) Rohit Ashiwal via GitGitGadget
2019-02-26 13:42 ` [PATCH 1/1] tests: replace `test -(d|f)` " Rohit Ashiwal via GitGitGadget
2019-02-26 14:04   ` Duy Nguyen
2019-02-26 16:10     ` Do test-path_is_{file,dir,exists} make sense anymore with -x? Ævar Arnfjörð Bjarmason
2019-02-26 17:04       ` SZEDER Gábor
2019-02-26 17:43         ` Jeff King
2019-02-26 19:39           ` SZEDER Gábor
2019-02-26 21:01             ` Jeff King
2019-03-03 16:04               ` SZEDER Gábor
2019-03-05  4:55                 ` Jeff King
2019-03-04 14:36               ` SZEDER Gábor [this message]
2019-03-05  4:58                 ` Jeff King
2019-02-26 17:48         ` Matthieu Moy
2019-02-26 18:24           ` Jeff King
2019-02-26 17:35       ` Jeff King
2019-02-26 19:58         ` Johannes Schindelin
2019-02-26 21:02           ` Jeff King
2019-02-27 10:01       ` Duy Nguyen
2019-03-01  2:52       ` Junio C Hamano
2019-02-26 16:01   ` [PATCH 1/1] tests: replace `test -(d|f)` with test_path_is_(dir|file) Johannes Schindelin
2019-02-26 16:30   ` Martin Ågren
2019-02-26 18:29     ` Rohit Ashiwal
2019-02-26 19:52       ` Johannes Schindelin
2019-02-26 20:01         ` Rohit Ashiwal
2019-02-27  5:49           ` Martin Ågren
2019-02-26 14:26 ` [PATCH v2 0/1] [GSoC][PATCH] t3600: use test_path_is_dir and test_path_is_file Rohit Ashiwal via GitGitGadget
2019-02-26 14:26   ` [PATCH v2 1/1] " Rohit Ashiwal via GitGitGadget
2019-02-26 16:37     ` SZEDER Gábor
2019-02-26 18:40       ` Rohit Ashiwal
2019-02-26 20:02         ` Johannes Schindelin
2019-02-26 20:05           ` Rohit Ashiwal
2019-02-26 22:48   ` [PATCH v3 0/1] [GSoC][PATCH] t3600: use test_path_is_* helper functions Rohit Ashiwal via GitGitGadget
2019-02-26 22:48     ` [PATCH v3 1/1] t3600: use test_path_is_* functions Rohit Ashiwal via GitGitGadget
2019-02-27 10:12       ` Duy Nguyen
2019-02-28 10:26     ` [PATCH v4 0/1] [GSoC][PATCH] t3600: use test_path_is_* helper functions Rohit Ashiwal via GitGitGadget
2019-02-28 10:26       ` [PATCH v4 1/1] t3600: use test_path_is_* functions Rohit Ashiwal via GitGitGadget
2019-02-28 19:02         ` [GSoC] acknowledging mistakes Rohit Ashiwal
2019-03-01  2:51           ` Junio C Hamano
2019-03-01 13:13             ` Feeling confused a little bit Rohit Ashiwal
2019-03-02  4:24               ` Rafael Ascensão
2019-03-02 14:46               ` Thomas Gummerer
2019-03-02 16:21                 ` [GSoC] Thanking Rohit Ashiwal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190304143633.GC28939@szeder.dev \
    --to=szeder.dev@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@matthieu-moy.fr \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    --cc=rohit.ashiwal265@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).