From: Jeff King <peff@peff.net>
To: Giuseppe Crino' <giuscri@gmail.com>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>,
"Pratyush Yadav" <me@yadavpratyush.com>,
"Emily Shaffer" <emilyshaffer@google.com>,
"Bryan Turner" <bturner@atlassian.com>,
"Git Users" <git@vger.kernel.org>
Subject: Re: [BUG] You can't have single quote in your username
Date: Wed, 28 Aug 2019 10:56:41 -0400 [thread overview]
Message-ID: <20190828145640.GC14432@sigill.intra.peff.net> (raw)
In-Reply-To: <20190828143315.GA4477@instance-template-2.europe-west6-a.c.vaulted-journal-250706.internal>
On Wed, Aug 28, 2019 at 02:33:15PM +0000, Giuseppe Crino' wrote:
> On Mon, Aug 26, 2019 at 03:14:55PM -0400, Jeff King wrote:
> > But we'd still need something at least for
> > GECOS, where "Your Name,,,," is common.
>
> As I understand this, those commas are *not* removed by
> strbuf_addstr_without_crud(). Instead they're skipped from /etc/pass
> -- see `ident.c/copy_gecos()`.
Yeah, you're right. This is a good example of how we are completely
unclear on how often the crud-removal is helping. :)
But I think that does put us one step closer to possibly dropping the
crud-removal, if gecos is already handled (and hopefully "mailinfo" is
already cleaning up the names it parsers).
-Peff
next prev parent reply other threads:[~2019-08-28 14:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 12:32 [BUG] You can't have single quote in your username Giuseppe Crinò
2019-08-22 15:06 ` Pratyush Yadav
2019-08-22 16:24 ` Junio C Hamano
2019-08-23 7:20 ` Giuseppe Crinò
2019-08-23 7:29 ` Michal Suchánek
2019-08-22 16:06 ` René Scharfe
2019-08-22 16:58 ` Bryan Turner
2019-08-22 17:08 ` Emily Shaffer
2019-08-22 18:43 ` Pratyush Yadav
2019-08-23 8:29 ` SZEDER Gábor
2019-08-23 9:35 ` Giuseppe Crinò
2019-08-23 10:15 ` SZEDER Gábor
2019-08-24 17:49 ` Giuseppe Crinò
2019-08-25 8:09 ` Giuseppe Crinò
2019-08-26 19:14 ` Jeff King
2019-08-27 13:51 ` Giuseppe Crino'
2019-08-27 14:33 ` Michal Suchánek
2019-08-28 14:33 ` Giuseppe Crino'
2019-08-28 14:56 ` Jeff King [this message]
2019-08-31 13:17 ` Giuseppe Crinò
2019-09-02 15:47 ` Jeff King
2019-09-02 19:25 ` Junio C Hamano
2019-09-02 19:50 ` Michal Suchánek
2019-09-03 7:51 ` Giuseppe Crinò
2019-09-03 9:03 ` Michal Suchánek
2019-08-23 8:26 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828145640.GC14432@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=bturner@atlassian.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=giuscri@gmail.com \
--cc=me@yadavpratyush.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).