git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Pratyush Yadav <me@yadavpratyush.com>
Cc: "Giuseppe Crinò" <giuscri@gmail.com>, git@vger.kernel.org
Subject: Re: [BUG] You can't have single quote in your username
Date: Thu, 22 Aug 2019 09:24:48 -0700	[thread overview]
Message-ID: <xmqqy2zlp3qn.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190822150614.o25g37pwfcaos2zn@localhost.localdomain> (Pratyush Yadav's message of "Thu, 22 Aug 2019 20:36:14 +0530")

Pratyush Yadav <me@yadavpratyush.com> writes:

> This strbuf_addstr_without_crud() function removes various characters 
> from the start and end of the author info, one of which is the single 
> quotation. I'm not sure why this is done, the more experienced folk 
> where will have the answer.

The logic there exists in order to remove cruft around the name on a
typical e-mail header (remember, most of the very core-ish part of
the Git was written and got solidified back when the Linux kernel
was the primary client of the system, and many commits were created
via "am"), e.g. sender's mail client may send something like this:

    From: 'Foo bar Baz' <my@name.xz>

and we do not want to take surrounding sq pair as part of the name.

  reply	other threads:[~2019-08-22 16:25 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-22 12:32 [BUG] You can't have single quote in your username Giuseppe Crinò
2019-08-22 15:06 ` Pratyush Yadav
2019-08-22 16:24   ` Junio C Hamano [this message]
2019-08-23  7:20     ` Giuseppe Crinò
2019-08-23  7:29       ` Michal Suchánek
2019-08-22 16:06 ` René Scharfe
2019-08-22 16:58 ` Bryan Turner
2019-08-22 17:08   ` Emily Shaffer
2019-08-22 18:43     ` Pratyush Yadav
2019-08-23  8:29       ` SZEDER Gábor
2019-08-23  9:35         ` Giuseppe Crinò
2019-08-23 10:15           ` SZEDER Gábor
2019-08-24 17:49         ` Giuseppe Crinò
2019-08-25  8:09           ` Giuseppe Crinò
2019-08-26 19:14         ` Jeff King
2019-08-27 13:51           ` Giuseppe Crino'
2019-08-27 14:33             ` Michal Suchánek
2019-08-28 14:33           ` Giuseppe Crino'
2019-08-28 14:56             ` Jeff King
2019-08-31 13:17           ` Giuseppe Crinò
2019-09-02 15:47             ` Jeff King
2019-09-02 19:25               ` Junio C Hamano
2019-09-02 19:50                 ` Michal Suchánek
2019-09-03  7:51                   ` Giuseppe Crinò
2019-09-03  9:03                     ` Michal Suchánek
2019-08-23  8:26     ` SZEDER Gábor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqy2zlp3qn.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=giuscri@gmail.com \
    --cc=me@yadavpratyush.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).