* [PATCH] builtin/commit-graph.c: remove subcommand-less usage string
@ 2019-10-25 16:49 SZEDER Gábor
2019-10-25 17:35 ` Derrick Stolee
0 siblings, 1 reply; 2+ messages in thread
From: SZEDER Gábor @ 2019-10-25 16:49 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Derrick Stolee, git, SZEDER Gábor
The first line in 'git commit-graph's usage string indicates that this
command can be invoked without specifying a subcommand. However, this
is not the case:
$ git commit-graph
usage: git commit-graph [--object-dir <objdir>]
or: git commit-graph read [--object-dir <objdir>]
[...]
$ echo $?
129
Remove this line from the usage string.
The synopsis in the manpage doesn't contain this line.
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
---
builtin/commit-graph.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/builtin/commit-graph.c b/builtin/commit-graph.c
index c6219ebe11..4d9b9c862f 100644
--- a/builtin/commit-graph.c
+++ b/builtin/commit-graph.c
@@ -8,7 +8,6 @@
#include "object-store.h"
static char const * const builtin_commit_graph_usage[] = {
- N_("git commit-graph [--object-dir <objdir>]"),
N_("git commit-graph read [--object-dir <objdir>]"),
N_("git commit-graph verify [--object-dir <objdir>] [--shallow] [--[no-]progress]"),
N_("git commit-graph write [--object-dir <objdir>] [--append|--split] [--reachable|--stdin-packs|--stdin-commits] [--[no-]progress] <split options>"),
--
2.24.0.rc1.539.g061db24550
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] builtin/commit-graph.c: remove subcommand-less usage string
2019-10-25 16:49 [PATCH] builtin/commit-graph.c: remove subcommand-less usage string SZEDER Gábor
@ 2019-10-25 17:35 ` Derrick Stolee
0 siblings, 0 replies; 2+ messages in thread
From: Derrick Stolee @ 2019-10-25 17:35 UTC (permalink / raw)
To: SZEDER Gábor, Junio C Hamano; +Cc: git
On 10/25/2019 12:49 PM, SZEDER Gábor wrote:
> The first line in 'git commit-graph's usage string indicates that this
> command can be invoked without specifying a subcommand. However, this
> is not the case:
>
> $ git commit-graph
> usage: git commit-graph [--object-dir <objdir>]
> or: git commit-graph read [--object-dir <objdir>]
> [...]
> $ echo $?
> 129
>
> Remove this line from the usage string.
>
> The synopsis in the manpage doesn't contain this line.
>
> Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
> ---
> builtin/commit-graph.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/builtin/commit-graph.c b/builtin/commit-graph.c
> index c6219ebe11..4d9b9c862f 100644
> --- a/builtin/commit-graph.c
> +++ b/builtin/commit-graph.c
> @@ -8,7 +8,6 @@
> #include "object-store.h"
>
> static char const * const builtin_commit_graph_usage[] = {
> - N_("git commit-graph [--object-dir <objdir>]"),
> N_("git commit-graph read [--object-dir <objdir>]"),
> N_("git commit-graph verify [--object-dir <objdir>] [--shallow] [--[no-]progress]"),
> N_("git commit-graph write [--object-dir <objdir>] [--append|--split] [--reachable|--stdin-packs|--stdin-commits] [--[no-]progress] <split options>"),
Good catch! Thanks for cleaning this up.
-Stolee
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-25 17:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-25 16:49 [PATCH] builtin/commit-graph.c: remove subcommand-less usage string SZEDER Gábor
2019-10-25 17:35 ` Derrick Stolee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).