From: Denton Liu <liu.denton@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>, Paul Jolly <paul@myitcv.io>
Subject: Re: [PATCH] completion: learn to complete `git rebase --onto=`
Date: Tue, 12 Nov 2019 10:05:03 -0800 [thread overview]
Message-ID: <20191112180503.GB41101@generichostname> (raw)
In-Reply-To: <xmqqpnhxg0ra.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On Tue, Nov 12, 2019 at 01:46:33PM +0900, Junio C Hamano wrote:
> Denton Liu <liu.denton@gmail.com> writes:
>
> > Before, when there was a space, we'd start a new word and, as a result,
> > fallback to __git_complete_refs() and `--onto` would be completed this
> > way. However, now we match the `--*` case which does not know how to
> > offer completions for refs.
>
> Very well explained. Thanks, will queue.
Could you please queue this on the tip of
'dl/complete-rebase-and-archive' since it fixes a regression introduced
in that branch?
Thanks,
Denton
next prev parent reply other threads:[~2019-11-12 18:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 19:51 Bug in bash completion for git rebase --onto Paul Jolly
2019-11-11 21:25 ` [PATCH] completion: learn to complete `git rebase --onto=` Denton Liu
2019-11-12 4:46 ` Junio C Hamano
2019-11-12 18:05 ` Denton Liu [this message]
2019-11-13 1:11 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112180503.GB41101@generichostname \
--to=liu.denton@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=paul@myitcv.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).