git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Jolly <paul@myitcv.io>
To: git@vger.kernel.org
Subject: Bug in bash completion for git rebase --onto
Date: Mon, 11 Nov 2019 19:51:08 +0000	[thread overview]
Message-ID: <CACoUkn6D0cUmN1RbcpfERcOJsbGLdwj6oDeF2oRADV+rX2artQ@mail.gmail.com> (raw)

Hi,

The bash completion for git rebase --onto seems to have been broken by
commit 2b9bd488ae09dc89f02be7d73f3710ee2ea7325c

Previously (v2.23.0), hitting tab after

    git rebase --on

gives:

    git rebase --onto

(note trailing space) hitting tab again offers a list of potential
refs onto which to rebase.

As of 2b9bd488ae09dc89f02be7d73f3710ee2ea7325c, hitting tab after:

    git rebase --on

gives:

    git rebase --onto=

but then hitting tab again offers the current directory contents as
candidates, i.e. not git ref candidates as they should be.

Note the adding of a trailing '=' is, I think, more correct/robust
than the trailing space so I don't disagree with that change. It's
just the failure to offer git ref candidates that is the problem.

Thanks,


Paul

             reply	other threads:[~2019-11-11 19:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-11 19:51 Paul Jolly [this message]
2019-11-11 21:25 ` [PATCH] completion: learn to complete `git rebase --onto=` Denton Liu
2019-11-12  4:46   ` Junio C Hamano
2019-11-12 18:05     ` Denton Liu
2019-11-13  1:11       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACoUkn6D0cUmN1RbcpfERcOJsbGLdwj6oDeF2oRADV+rX2artQ@mail.gmail.com \
    --to=paul@myitcv.io \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).