git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Jeffrey Walton <noloader@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: git-compat-util.h:798:13: error: conflicting types for ‘inet_ntop’
Date: Mon, 3 Feb 2020 06:02:49 -0500	[thread overview]
Message-ID: <20200203110249.GA4153124@coredump.intra.peff.net> (raw)
In-Reply-To: <CAH8yC8mmNXGw13zkrmxxJFQKEsmGqkKHFp13+U7==umHM2WR_Q@mail.gmail.com>

On Mon, Feb 03, 2020 at 05:46:53AM -0500, Jeffrey Walton wrote:

> Below is from configure.ac around line 720
> (https://github.com/git/git/blob/master/configure.ac#L722).
> 
> I think the test program needs to include <arpa/inet.h>.

I don't know very much about autoconf, but I'm not sure we need to worry
about the header. Looking at the generated "configure" script, I think
it puts in a dummy prototype, and just confirms that the linker is able
to find it (the resulting test-program would obviously behave poorly,
but we don't try to run it).

> Then, if the current -lresolv test fails, configure should use the
> same program and check -lsocket -lnls.

Yeah, that makes sense. Though there is a test above for -lsocket, and
if it works, then we put "-lsocket" into $LIBS in the configure script.
And I _think_ that means that subsequent tests would already be trying
with -lsocket, and we might just need a similar test for -lnsl (but
again, my autoconf is quite rusty).

You might get more information by looking at the output in config.log to
see the actual compiler/linker output during the inet_ntop test, and why
the link fails.

-Peff

      reply	other threads:[~2020-02-03 11:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-01 11:39 git-compat-util.h:798:13: error: conflicting types for ‘inet_ntop’ Jeffrey Walton
2020-02-01 12:12 ` Jeffrey Walton
2020-02-01 12:34   ` Jeffrey Walton
2020-02-03  8:54   ` Jeff King
2020-02-03  8:59     ` Jeffrey Walton
2020-02-03 10:01       ` Jeff King
2020-02-03 10:46     ` Jeffrey Walton
2020-02-03 11:02       ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200203110249.GA4153124@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=noloader@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).