git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: "Martin Ågren" <martin.agren@gmail.com>
Cc: "brian m. carlson" <sandals@crustytoothpaste.ath.cx>,
	git@vger.kernel.org
Subject: Re: [PATCH 0/6] Doc: drop support for docbook-xsl before 1.74
Date: Wed, 1 Apr 2020 06:17:16 -0400	[thread overview]
Message-ID: <20200401101716.GC60227@coredump.intra.peff.net> (raw)
In-Reply-To: <20200331192600.588-1-martin.agren@gmail.com>

On Tue, Mar 31, 2020 at 09:26:00PM +0200, Martin Ågren wrote:

> But most importantly: When I looked into the history, I came upon
> c2a7f5d438 ("docs: monospace listings in docbook output", 2012-08-07),
> which made me worry about breaking "make info". On second thought, I
> might have broken it many times already over the past few years, since
> I've never built the info. So maybe worrying about that all of a sudden
> is a bit unfounded in a way. :-/
> 
> (I tried to build "info" while working on this. It works in the sense
> that it doesn't error out, but I don't get anything that looks remotely
> useful. I've never used info at all though, to be honest, so could be
> missing something fundamental.)

I don't find "info" useful, either. The big thing it offers over "man"
is actual hyperlinks, but linkgit attributes (the only thing we actually
bother annotating) don't seem to actually become links! These days I'd
expect most people interested in hyperlinking to just use HTML.  I
wouldn't be surprised if there's some emacs integration with info,
though, so maybe people use it there. I dunno. I'd be happy to see all
of the info bits go away.

I've add brian to the cc, since he was the last person to touch texi
stuff (though he may have just been doing it out of a sense of
cleanup/duty).

The .texi generated for the user-manual is the same before and after
your patch, so I think it's OK to do.

There _is_ an older regression in the user-manual, though. After commit
03920ac69b (asciidoctor: fix user-manual to be built by `asciidoctor`,
2017-01-02), the whole front-matter is missing from the generated
"git.info" file, and there's a funky ": idm4" node. Nobody seems to have
noticed or complained since then (though perhaps people are more likely
to look at the manpages than the user manual).

> -- >8 --
> Subject: [PATCH 7/6?] user-manual.conf: don't specify [listingblock]

Yeah, this looks good to me (and it looks like Junio already picked it
up on top of your series).

-Peff

  reply	other threads:[~2020-04-01 10:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-29 13:18 Martin Ågren
2020-03-29 13:18 ` [PATCH 1/6] Doc: drop support for docbook-xsl before 1.71.1 Martin Ågren
2020-03-29 13:18 ` [PATCH 2/6] Doc: drop support for docbook-xsl before 1.72.0 Martin Ågren
2020-03-29 13:18 ` [PATCH 3/6] Doc: drop support for docbook-xsl before 1.73.0 Martin Ågren
2020-03-29 13:18 ` [PATCH 4/6] manpage-bold-literal.xsl: stop using git.docbook.backslash Martin Ågren
2020-03-29 13:18 ` [PATCH 5/6] manpage-normal.xsl: fold in manpage-base.xsl Martin Ågren
2020-03-29 13:18 ` [PATCH 6/6] INSTALL: drop support for docbook-xsl before 1.74 Martin Ågren
2020-03-30  9:26   ` Jeff King
2020-03-29 16:27 ` [PATCH 0/6] Doc: " Junio C Hamano
2020-03-30  9:45 ` Jeff King
2020-03-31 19:26   ` Martin Ågren
2020-04-01 10:17     ` Jeff King [this message]
2020-04-01 16:59       ` Junio C Hamano
2020-04-02  0:45       ` brian m. carlson
2020-04-02 16:48         ` Junio C Hamano
2020-03-30 10:46 ` brian m. carlson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200401101716.GC60227@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=martin.agren@gmail.com \
    --cc=sandals@crustytoothpaste.ath.cx \
    --subject='Re: [PATCH 0/6] Doc: drop support for docbook-xsl before 1.74' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).