* [PATCH] gitweb: Recognize *-to and Closes/Fixes trailers
@ 2020-04-25 2:17 Emma Brooks
2020-04-25 5:17 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Emma Brooks @ 2020-04-25 2:17 UTC (permalink / raw)
To: git; +Cc: Jakub Narębski, Namhyung Kim, Emma Brooks
Commit trailers like "Thanks-to:", "Fixes:", and "Closes:" are fairly
common, but gitweb didn't highlight them like other trailers.
Signed-off-by: Emma Brooks <me@pluvano.com>
---
gitweb/gitweb.perl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 1a02a1242d..0959a782ec 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -4641,7 +4641,7 @@ sub git_print_log {
# print log
my $skip_blank_line = 0;
foreach my $line (@$log) {
- if ($line =~ m/^\s*([A-Z][-A-Za-z]*-[Bb]y|C[Cc]): /) {
+ if ($line =~ m/^\s*([A-Z][-A-Za-z]*-([Bb]y|[Tt]o)|C[Cc]|(Clos|Fix)es): /) {
if (! $opts{'-remove_signoff'}) {
print "<span class=\"signoff\">" . esc_html($line) . "</span><br/>\n";
$skip_blank_line = 1;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gitweb: Recognize *-to and Closes/Fixes trailers
2020-04-25 2:17 [PATCH] gitweb: Recognize *-to and Closes/Fixes trailers Emma Brooks
@ 2020-04-25 5:17 ` Junio C Hamano
2020-04-25 6:29 ` Emma Brooks
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2020-04-25 5:17 UTC (permalink / raw)
To: Emma Brooks; +Cc: git, Jakub Narębski, Namhyung Kim
Emma Brooks <me@pluvano.com> writes:
> Commit trailers like "Thanks-to:", "Fixes:", and "Closes:" are fairly
> common, but gitweb didn't highlight them like other trailers.
Did you also sneak "cc" in without documenting/justifying?
When the re becomes this complex, it may not be a bad idea to switch
to "/ ignore most whitespaces /x" style for readability.
> - if ($line =~ m/^\s*([A-Z][-A-Za-z]*-[Bb]y|C[Cc]): /) {
> + if ($line =~ m/^\s*([A-Z][-A-Za-z]*-([Bb]y|[Tt]o)|C[Cc]|(Clos|Fix)es): /) {
if ($line =~ m/^\s*([A-Z][-A-Za-z]*-([Bb]y|[Tt]o) |
C[Cc] | Closes | Fixes ):\s /x) {
Well, I am sloppy and did not make it all that easier to read.
More experienced Perl folks certainly would be able to teach us a
much better convention to format things like this more readble.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gitweb: Recognize *-to and Closes/Fixes trailers
2020-04-25 5:17 ` Junio C Hamano
@ 2020-04-25 6:29 ` Emma Brooks
0 siblings, 0 replies; 3+ messages in thread
From: Emma Brooks @ 2020-04-25 6:29 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, Jakub Narębski, Namhyung Kim
On 2020-04-24 22:17:58-0700, Junio C Hamano wrote:
> Did you also sneak "cc" in without documenting/justifying?
No, that was already there in the original, before the colon:
> > - if ($line =~ m/^\s*([A-Z][-A-Za-z]*-[Bb]y|C[Cc]): /) {
> > + if ($line =~ m/^\s*([A-Z][-A-Za-z]*-([Bb]y|[Tt]o)|C[Cc]|(Clos|Fix)es): /) {
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-25 6:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-25 2:17 [PATCH] gitweb: Recognize *-to and Closes/Fixes trailers Emma Brooks
2020-04-25 5:17 ` Junio C Hamano
2020-04-25 6:29 ` Emma Brooks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).