From: Jeff King <email@example.com> To: "Daniel Richard G." <skunk@iSKUNK.ORG> Cc: firstname.lastname@example.org Subject: Re: Minor portability issues + fixes Date: Wed, 20 May 2020 00:28:38 -0400 Message-ID: <20200520042838.GA102274@coredump.intra.peff.net> (raw) In-Reply-To: <email@example.com> On Tue, May 19, 2020 at 12:22:00AM -0400, Daniel Richard G. wrote: > > If so, then perhaps it should be added to the AIX defines in > > config.mak.uname. > > I've confirmed that this works. But would it not be safe to #include > both inttypes.h and stdint.h explicitly if both are present, rather than > cater to AIX specifically? I could see this similarly arising in, say, > an old version of Solaris. Yes, as long as we check that both are present, I think that would do the right thing. And the autoconf check could cover that. I don't think there's an easy way to have a general Makefile knob that can check which files are present, though (and we generally consider the Makefile and its knobs to be the primary mechanism; autoconf to turn those knobs is generally implemented on top). So probably we'd want something like (in this order): - NEEDS_EXPLICIT_STDINT gets passed from the Makefile into the compiler via -D, which then triggers stdint.h being included unconditionally in git-compat-util.h - optionally set that in config.mak.uname for AIX (checking uname_R since it sounds like only old versions need it) - add an autoconf rule that sets it, either strictly (when a test-program decides it's needed) or loosely (when we see that it's available at all) Even just the first one would let you build by setting the knob manually; the rest is gravy on top, if you or somebody else chooses to do it. > > I do wonder, though, if configure.ac could be extended for AIX to > > support whatever syntax the system linker uses for setting the run-path. > > I understand that you don't care either way about this feature, but this > > might be a good opportunity to fix it. > > This could be a bit complicated, I'm afraid. > > The applicable value for CC_LD_DYNPATH on AIX is "-Wl,-blibpath:". > However, have a look at the description for this option in the > ld(1) man page: OK, gross. :) I agree it's not worth going too far into this rabbit hole. I do wonder if you could just be using GNU ld along with gcc, but maybe that's not practical. You should be able to build with: make CC_LD_DYNPATH=-L as a workaround, but it would be nice if the Makefile handled this correctly. It looks like CC_LD_DYNPATH gets used in a lot of places, so I suspect we'd want a Makefile function to help out. Something like: # usage: $(call linker_lib,PATH) # Create linker args for looking for libraries in PATH at both link-time # and run-time. linker_lib = -L$1 $(if $(CC_LD_DYNPATH),$(CC_LD_DYNPATH)$1) which would allow: EXTLIBS += $(call linker_lib,$(LIBPCREDIR)/$(lib)) etc. This would be our first foray into Makefile functions, but I think we've determined that most platforms have a recent enough GNU make for it to be OK (and we already require GNU make). -Peff
next prev parent reply index Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-19 1:15 Daniel Richard G. 2020-05-19 2:49 ` Jeff King 2020-05-19 4:22 ` Daniel Richard G. 2020-05-20 4:28 ` Jeff King [this message] 2020-05-21 4:29 ` Daniel Richard G. 2020-05-22 20:03 ` Jeff King 2020-05-19 3:04 ` Carlo Marcelo Arenas Belón 2020-05-19 4:26 ` Daniel Richard G.
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200520042838.GA102274@coredump.intra.peff.net \ --firstname.lastname@example.org \ --email@example.com \ --cc=skunk@iSKUNK.ORG \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Mailing List Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/git/0 git/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 git git/ https://lore.kernel.org/git \ firstname.lastname@example.org public-inbox-index git Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git