From: Jonathan Nieder <email@example.com> To: Johannes Schindelin <Johannes.Schindelin@gmx.de> Cc: Junio C Hamano <firstname.lastname@example.org>, Josh Steadmon <email@example.com>, "brian m. carlson" <firstname.lastname@example.org>, Derrick Stolee <email@example.com>, Derrick Stolee via GitGitGadget <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, email@example.com, Derrick Stolee <firstname.lastname@example.org> Subject: Re: [PATCH 00/15] [RFC] Maintenance jobs and job runner Date: Thu, 28 May 2020 07:50:18 -0700 [thread overview] Message-ID: <20200528145018.GA58643@google.com> (raw) In-Reply-To: <nycvar.QRO.email@example.com> Hi, Johannes Schindelin wrote: > So while `git gc` looks like a good candidate on its technical merits, the > usability/discoverability point of view paints a very different picture. Here is what I take away from that comment: It was a mistake for "git gc" to take responsibility for operations like "git pack-refs". We should migrate to a new "git maintenance run" command and make "git gc" print a signpost to help people find the new name. That seems like a reasonable direction to me, but as you're hinting, from a technical design perspective it doesn't change where e.g. midx maintenance operations would go. I would expect the routine maintenance command, whatever it is called, to perform such operations. I would not expect to have to choose between two subtly different maintenance commands, or in other words to have to pay as a user for an unrelated naming choice. I think it's worth discussing naming, but it's kind of a distraction from what Brian brought up. The real question is, do we consider the existing "git gc" infrastructure such a lost cause that we should touch it as little as possible? I don't think that was Stolee's intent --- instead, I supsect that it was just the discoverability issue you mention that led to this series forgetting about the possibility of incorporating this functionality into "git gc". [...] > I guess I would argue for the introduction of a new command, like `git > maintenance`, which could potentially trigger a `git gc --auto`, but is > primarily intended to run _outside_ of the users' work hours. > > Once we have that, we can always figure out whether there is a convenient > way to register this via `crontab` or Windows Task Scheduler, without > asking the users to do all of these tedious steps manually. Wonderful, it sounds like we're pretty much in agreement. [...] > Therefore, I would like very much to have a `git maintenance --schedule` > (or something like that), even if only on Windows, on the grounds alone > that it is even more tedious to work with the Windows Task Scheduler. But > I would prefer to have that also in my Linux setup. The convenience for > the users (myself included) is just too compelling. I think Josh was arguing for deferring that part to a separate series. Otherwise we could end up spending so much time focusing on scheduling and service supervision that the series gets delayed and no one benefits from Stolee's work to improve how routine packing works. Thanks, Jonathan
next prev parent reply other threads:[~2020-05-28 14:50 UTC|newest] Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-03 20:47 Derrick Stolee via GitGitGadget 2020-04-03 20:48 ` [PATCH 01/15] run-job: create barebones builtin Derrick Stolee via GitGitGadget 2020-04-05 15:10 ` Phillip Wood 2020-04-05 19:21 ` Junio C Hamano 2020-04-06 14:42 ` Derrick Stolee 2020-04-07 0:58 ` Danh Doan 2020-04-07 10:54 ` Derrick Stolee 2020-04-07 14:16 ` Danh Doan 2020-04-07 14:30 ` Johannes Schindelin 2020-04-03 20:48 ` [PATCH 02/15] run-job: implement commit-graph job Derrick Stolee via GitGitGadget 2020-05-20 19:08 ` Josh Steadmon 2020-04-03 20:48 ` [PATCH 03/15] run-job: implement fetch job Derrick Stolee via GitGitGadget 2020-04-05 15:14 ` Phillip Wood 2020-04-06 12:48 ` Derrick Stolee 2020-04-05 20:28 ` Junio C Hamano 2020-04-06 12:46 ` Derrick Stolee 2020-05-20 19:08 ` Josh Steadmon 2020-04-03 20:48 ` [PATCH 04/15] run-job: implement loose-objects job Derrick Stolee via GitGitGadget 2020-04-05 20:33 ` Junio C Hamano 2020-04-03 20:48 ` [PATCH 05/15] run-job: implement pack-files job Derrick Stolee via GitGitGadget 2020-05-27 22:17 ` Josh Steadmon 2020-04-03 20:48 ` [PATCH 06/15] run-job: auto-size or use custom pack-files batch Derrick Stolee via GitGitGadget 2020-04-03 20:48 ` [PATCH 07/15] config: add job.pack-files.batchSize option Derrick Stolee via GitGitGadget 2020-04-03 20:48 ` [PATCH 08/15] job-runner: create builtin for job loop Derrick Stolee via GitGitGadget 2020-04-03 20:48 ` [PATCH 09/15] job-runner: load repos from config by default Derrick Stolee via GitGitGadget 2020-04-05 15:18 ` Phillip Wood 2020-04-06 12:49 ` Derrick Stolee 2020-04-05 15:41 ` Phillip Wood 2020-04-06 12:57 ` Derrick Stolee 2020-04-03 20:48 ` [PATCH 10/15] job-runner: use config to limit job frequency Derrick Stolee via GitGitGadget 2020-04-05 15:24 ` Phillip Wood 2020-04-03 20:48 ` [PATCH 11/15] job-runner: use config for loop interval Derrick Stolee via GitGitGadget 2020-04-03 20:48 ` [PATCH 12/15] job-runner: add --interval=<span> option Derrick Stolee via GitGitGadget 2020-04-03 20:48 ` [PATCH 13/15] job-runner: skip a job if job.<job-name>.enabled is false Derrick Stolee via GitGitGadget 2020-04-03 20:48 ` [PATCH 14/15] job-runner: add --daemonize option Derrick Stolee via GitGitGadget 2020-04-03 20:48 ` [PATCH 15/15] runjob: customize the loose-objects batch size Derrick Stolee via GitGitGadget 2020-04-03 21:40 ` [PATCH 00/15] [RFC] Maintenance jobs and job runner Junio C Hamano 2020-04-04 0:16 ` Derrick Stolee 2020-04-07 0:50 ` Danh Doan 2020-04-07 10:59 ` Derrick Stolee 2020-04-07 14:26 ` Danh Doan 2020-04-07 14:43 ` Johannes Schindelin 2020-04-07 1:48 ` brian m. carlson 2020-04-07 20:08 ` Junio C Hamano 2020-04-07 22:23 ` Johannes Schindelin 2020-04-08 0:01 ` brian m. carlson 2020-05-27 22:39 ` Josh Steadmon 2020-05-28 0:47 ` Junio C Hamano 2020-05-27 21:52 ` Johannes Schindelin 2020-05-28 14:48 ` Junio C Hamano 2020-05-28 14:50 ` Jonathan Nieder [this message] 2020-05-28 14:57 ` Junio C Hamano 2020-05-28 15:03 ` Jonathan Nieder 2020-05-28 15:30 ` Derrick Stolee 2020-05-28 4:39 ` Johannes Schindelin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200528145018.GA58643@google.com \ --firstname.lastname@example.org \ --cc=Johannes.Schindelin@gmx.de \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 00/15] [RFC] Maintenance jobs and job runner' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).