git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] upload-pack: do not lazy-fetch "have" objects
Date: Mon, 20 Jul 2020 13:42:03 -0400	[thread overview]
Message-ID: <20200720174203.GB2046890@coredump.intra.peff.net> (raw)
In-Reply-To: <20200716180950.2852753-1-jonathantanmy@google.com>

On Thu, Jul 16, 2020 at 11:09:50AM -0700, Jonathan Tan wrote:

> Differences from v1: OBJECT_INFO_QUICK is also used wherever
> OBJECT_INFO_SKIP_FETCH_OBJECT is added.
> 
> Using OBJECT_INFO_QUICK makes sense to me, so here's an updated patch.

Yeah, I think this is reasonable, and the patch looks good to me.

-Peff

      reply	other threads:[~2020-07-20 17:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-15 22:31 [PATCH] upload-pack: do not lazy-fetch "have" objects Jonathan Tan
2020-07-15 22:55 ` Junio C Hamano
2020-07-16 10:41   ` Jeff King
2020-07-16 17:36     ` Junio C Hamano
2020-07-16 18:09       ` [PATCH v2] " Jonathan Tan
2020-07-20 17:42         ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200720174203.GB2046890@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=jonathantanmy@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).