git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Jonathan Tan <jonathantanmy@google.com>, git@vger.kernel.org
Subject: Re: [PATCH] upload-pack: do not lazy-fetch "have" objects
Date: Thu, 16 Jul 2020 10:36:09 -0700	[thread overview]
Message-ID: <xmqqk0z3gy5y.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200716104149.GA376357@coredump.intra.peff.net> (Jeff King's message of "Thu, 16 Jul 2020 06:41:49 -0400")

Jeff King <peff@peff.net> writes:

> I think the instance fixed here _probably_ could be converted to QUICK
> as well. It saves extra refreshes of the pack directory when a client
> asks for an object we don't have. That's usually not too expensive, but
> can be in some cases (many alternates, slow NFS filesystems, client has
> many objects we don't). In the worst case, using QUICK would mean we can
> get fooled by a simultaneous repack into thinking we don't have an
> object we _do_ have, and end up negotiating a worse pack for the client.
>
>> Thanks.  Will queue.
>
> That said, yeah, I think Jonathan's patch is a strict improvement by
> itself.

I'll see what Jonathan would say, hoping that he'd consider if QUICK
is appropriate or not sufficiently enough to result in an updated
patch, that either has QUICK in the code or the reason why QUICK is
not used in the log message.

Thanks.

  reply	other threads:[~2020-07-16 17:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-15 22:31 [PATCH] upload-pack: do not lazy-fetch "have" objects Jonathan Tan
2020-07-15 22:55 ` Junio C Hamano
2020-07-16 10:41   ` Jeff King
2020-07-16 17:36     ` Junio C Hamano [this message]
2020-07-16 18:09       ` [PATCH v2] " Jonathan Tan
2020-07-20 17:42         ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqk0z3gy5y.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jonathantanmy@google.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).