From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Cc: Eric Sunshine <sunshine@sunshineco.com>,
Phillip Wood <phillip.wood123@gmail.com>,
Michael J Gruber <git@grubix.eu>
Subject: [PATCH 0/4] some chainlint fixes and performance improvements
Date: Tue, 28 Mar 2023 16:20:43 -0400 [thread overview]
Message-ID: <20230328202043.GA1241391@coredump.intra.peff.net> (raw)
Here are a few fixes for chainlint. The first patch should avoid the
confusion we discussed in the subthread at:
https://lore.kernel.org/git/3714ba2f6528c38eb9c438126316a08b0cefca7c.1679696180.git.git@grubix.eu/
and the relevant folks are cc'd. The rest are some old performance
improvement ideas I had for the internal chain-linter. I doubt they make
a huge difference overall, but they can be measured in certain cases.
The first one to me looks like an obvious win. The second one is
debatable, as it involves some hand-waving. The third one turned out not
to make anything faster, but makes the code a little simpler.
So I'm on the fence for patches 3 and 4 below, but the first two I think
are strict improvements.
[1/4]: tests: run internal chain-linter under "make test"
[2/4]: tests: replace chainlint subshell with a function
[3/4]: tests: drop here-doc check from internal chain-linter
[4/4]: tests: skip test_eval_ in internal chain-lint
t/Makefile | 2 +-
t/test-lib.sh | 27 ++++++++++++++-------------
2 files changed, 15 insertions(+), 14 deletions(-)
-Peff
next reply other threads:[~2023-03-28 20:20 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 20:20 Jeff King [this message]
2023-03-28 20:22 ` [PATCH 1/4] tests: run internal chain-linter under "make test" Jeff King
2023-03-29 10:20 ` Ævar Arnfjörð Bjarmason
2023-03-29 15:49 ` Junio C Hamano
2023-03-29 23:28 ` Jeff King
2023-03-30 18:45 ` Junio C Hamano
2023-03-28 20:23 ` [PATCH 2/4] tests: replace chainlint subshell with a function Jeff King
2023-03-28 20:40 ` Junio C Hamano
2023-03-28 20:28 ` [PATCH 3/4] tests: drop here-doc check from internal chain-linter Jeff King
2023-03-28 21:46 ` Junio C Hamano
2023-03-29 2:37 ` Jeff King
2023-03-29 3:04 ` Jeff King
2023-03-29 3:13 ` Eric Sunshine
2023-03-29 3:46 ` Eric Sunshine
2023-03-29 4:02 ` Eric Sunshine
2023-03-29 6:07 ` Jeff King
2023-03-29 6:28 ` Eric Sunshine
2023-03-29 3:07 ` Eric Sunshine
2023-03-29 6:28 ` Jeff King
2023-03-28 20:28 ` [PATCH 4/4] tests: skip test_eval_ in internal chain-lint Jeff King
2023-03-28 21:08 ` [PATCH 0/4] some chainlint fixes and performance improvements Jeff King
2023-03-30 22:08 ` Jeff King
2023-03-30 22:16 ` Junio C Hamano
2023-03-30 19:27 ` [PATCH v2 0/5] " Jeff King
2023-03-30 19:27 ` [PATCH v2 1/5] tests: run internal chain-linter under "make test" Jeff King
2023-03-30 19:27 ` [PATCH v2 2/5] tests: replace chainlint subshell with a function Jeff King
2023-03-30 19:30 ` [PATCH v2 3/5] tests: diagnose unclosed here-doc in chainlint.pl Jeff King
2023-03-30 21:26 ` Eric Sunshine
2023-03-30 19:30 ` [PATCH v2 4/5] tests: drop here-doc check from internal chain-linter Jeff King
2023-03-30 19:30 ` [PATCH v2 5/5] tests: skip test_eval_ in internal chain-lint Jeff King
2023-03-30 20:32 ` [PATCH v2 0/5] some chainlint fixes and performance improvements Junio C Hamano
2023-03-30 22:09 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230328202043.GA1241391@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@grubix.eu \
--cc=git@vger.kernel.org \
--cc=phillip.wood123@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).