* [PATCH] index-format.txt: remove outdated list of supported extensions
@ 2022-07-18 8:56 SZEDER Gábor
2022-07-18 13:35 ` Ævar Arnfjörð Bjarmason
2022-07-18 16:24 ` Junio C Hamano
0 siblings, 2 replies; 3+ messages in thread
From: SZEDER Gábor @ 2022-07-18 8:56 UTC (permalink / raw)
To: git; +Cc: SZEDER Gábor
The first section of 'Documentation/technical/index-format.txt'
mentions that "Git currently supports cache tree and resolve undo
extensions", but then goes on, and in the "Extensions" section
describes not only these two, but six other extensions [1].
Remove this sentence, as it's misleading about the status of all those
other extensions.
Alternatively we could keep that sentence and update the list of
extensions, but that might well lead to a recurring issue, because
apparently this list is never updated when a new index extension is
added.
[1] Split index, untracked cache, FS monitor cache, end of index
entry, index entry offset table and sparse directory entries.
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
---
Documentation/technical/index-format.txt | 2 --
1 file changed, 2 deletions(-)
diff --git a/Documentation/technical/index-format.txt b/Documentation/technical/index-format.txt
index 65da0daaa5..f691c20ab0 100644
--- a/Documentation/technical/index-format.txt
+++ b/Documentation/technical/index-format.txt
@@ -26,8 +26,6 @@ Git index format
Extensions are identified by signature. Optional extensions can
be ignored if Git does not understand them.
- Git currently supports cache tree and resolve undo extensions.
-
4-byte extension signature. If the first byte is 'A'..'Z' the
extension is optional and can be ignored.
--
2.37.1.527.g8ff01757f9
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] index-format.txt: remove outdated list of supported extensions
2022-07-18 8:56 [PATCH] index-format.txt: remove outdated list of supported extensions SZEDER Gábor
@ 2022-07-18 13:35 ` Ævar Arnfjörð Bjarmason
2022-07-18 16:24 ` Junio C Hamano
1 sibling, 0 replies; 3+ messages in thread
From: Ævar Arnfjörð Bjarmason @ 2022-07-18 13:35 UTC (permalink / raw)
To: SZEDER Gábor; +Cc: git
On Mon, Jul 18 2022, SZEDER Gábor wrote:
> The first section of 'Documentation/technical/index-format.txt'
> mentions that "Git currently supports cache tree and resolve undo
> extensions", but then goes on, and in the "Extensions" section
> describes not only these two, but six other extensions [1].
>
> Remove this sentence, as it's misleading about the status of all those
> other extensions.
>
> Alternatively we could keep that sentence and update the list of
> extensions, but that might well lead to a recurring issue, because
> apparently this list is never updated when a new index extension is
> added.
>
> [1] Split index, untracked cache, FS monitor cache, end of index
> entry, index entry offset table and sparse directory entries.
>
> Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
> ---
> Documentation/technical/index-format.txt | 2 --
> 1 file changed, 2 deletions(-)
Note that there's a conflict with my series to move this to
gitformat-index(5), although the conflict is easily solved:
https://lore.kernel.org/git/patch-v4-6.8-858ce9c6999-20220718T132911Z-avarab@gmail.com/
> diff --git a/Documentation/technical/index-format.txt b/Documentation/technical/index-format.txt
> index 65da0daaa5..f691c20ab0 100644
> --- a/Documentation/technical/index-format.txt
> +++ b/Documentation/technical/index-format.txt
> @@ -26,8 +26,6 @@ Git index format
> Extensions are identified by signature. Optional extensions can
> be ignored if Git does not understand them.
>
> - Git currently supports cache tree and resolve undo extensions.
> -
> 4-byte extension signature. If the first byte is 'A'..'Z' the
> extension is optional and can be ignored.
I wonder if we should instead say : git currently supports various index
extensions, see <asciidoc syntax to link to section below>.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] index-format.txt: remove outdated list of supported extensions
2022-07-18 8:56 [PATCH] index-format.txt: remove outdated list of supported extensions SZEDER Gábor
2022-07-18 13:35 ` Ævar Arnfjörð Bjarmason
@ 2022-07-18 16:24 ` Junio C Hamano
1 sibling, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2022-07-18 16:24 UTC (permalink / raw)
To: SZEDER Gábor; +Cc: git
SZEDER Gábor <szeder.dev@gmail.com> writes:
> The first section of 'Documentation/technical/index-format.txt'
> mentions that "Git currently supports cache tree and resolve undo
> extensions", but then goes on, and in the "Extensions" section
> describes not only these two, but six other extensions [1].
>
> Remove this sentence, as it's misleading about the status of all those
> other extensions.
>
> Alternatively we could keep that sentence and update the list of
> extensions, but that might well lead to a recurring issue, because
> apparently this list is never updated when a new index extension is
> added.
Yup, I tend to agree that the sentence does not add much being here
and insisting that the list must be kept up to date creates more
work of dubious value. If we didn't support any extensions, we
wouldn't be talking about them in this section, so saying that we
support some and we will list them later does not add much value,
either.
> [1] Split index, untracked cache, FS monitor cache, end of index
> entry, index entry offset table and sparse directory entries.
>
> Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
> ---
> Documentation/technical/index-format.txt | 2 --
> 1 file changed, 2 deletions(-)
Thanks, will queue.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-18 16:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-18 8:56 [PATCH] index-format.txt: remove outdated list of supported extensions SZEDER Gábor
2022-07-18 13:35 ` Ævar Arnfjörð Bjarmason
2022-07-18 16:24 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).