From: Derrick Stolee <stolee@gmail.com>
To: Eric Sunshine <sunshine@sunshineco.com>,
Junio C Hamano <gitster@pobox.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Git List" <git@vger.kernel.org>
Subject: Re: [PATCH] CodingGuidelines: recommend gender-neutral description
Date: Thu, 15 Jul 2021 13:27:55 -0400 [thread overview]
Message-ID: <2bdd27b7-cbe1-6952-eca0-f6fcecdaec8c@gmail.com> (raw)
In-Reply-To: <CAPig+cT24=jy65C1cQ4WarakJHKm4F8_78nDm=jWOnHxfhtcRw@mail.gmail.com>
On 7/15/2021 12:35 PM, Eric Sunshine wrote:
> On Thu, Jul 15, 2021 at 12:25 PM Junio C Hamano <gitster@pobox.com> wrote:
>> diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
>> @@ -541,6 +541,49 @@ Writing Documentation:
>> + A contributor asks their upstream to pull from them.
>> +
>> + Note that this sounds ungrammatical and unnatural to those who
>> + learned English as a second language in some parts of the world.
>
> It also sounds ungrammatical and unnatural to this native English speaker.
A way to adapt this idea more generally would be to pull a phrase
from my commit message in v3:
Note that this sounds ungrammatical and unnatural to readers
who learned English in a way that dictated "they" as always plural.
Learning English as a second language is one example of how one could
find it ungrammatical. We could call it out explicitly:
Note that this sounds ungrammatical and unnatural to readers
who learned English in a way that dictated "they" as always plural,
especially those who learned English as a second language.
Thanks,
-Stolee
next prev parent reply other threads:[~2021-07-15 17:28 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 1:07 What's cooking in git.git (Jul 2021, #03; Tue, 13) Junio C Hamano
2021-07-14 2:16 ` Eric Sunshine
2021-07-14 16:30 ` Junio C Hamano
2021-07-14 22:39 ` Eric Sunshine
2021-07-14 22:44 ` Junio C Hamano
2021-07-14 8:42 ` Han-Wen Nienhuys
2021-07-14 11:53 ` Ævar Arnfjörð Bjarmason
2021-07-14 11:54 ` Ævar Arnfjörð Bjarmason
2021-07-14 17:28 ` Junio C Hamano
2021-07-14 13:11 ` Derrick Stolee
2021-07-14 14:32 ` Ævar Arnfjörð Bjarmason
2021-07-15 16:25 ` [PATCH] CodingGuidelines: recommend gender-neutral description Junio C Hamano
2021-07-15 16:35 ` Eric Sunshine
2021-07-15 16:47 ` Taylor Blau
2021-07-15 18:02 ` Junio C Hamano
2021-07-16 21:25 ` Felipe Contreras
2021-07-15 17:27 ` Derrick Stolee [this message]
2021-07-16 15:11 ` Johannes Schindelin
2021-07-16 21:22 ` Felipe Contreras
2021-07-16 18:41 ` [PATCH v2] " Junio C Hamano
2021-07-16 19:05 ` Derrick Stolee
2021-07-16 19:11 ` Ævar Arnfjörð Bjarmason
2021-07-16 19:50 ` Junio C Hamano
2021-07-16 21:14 ` Felipe Contreras
2021-08-12 8:35 ` [PATCH] " Bagas Sanjaya
2021-07-14 20:11 ` What's cooking in git.git (Jul 2021, #03; Tue, 13) Taylor Blau
2021-07-19 7:35 ` Patrick Steinhardt
2021-07-19 7:53 ` Felipe Contreras
2021-07-19 8:35 ` Jeff King
2021-07-19 10:42 ` Felipe Contreras
2021-07-19 10:56 ` Patrick Steinhardt
2021-07-19 11:25 ` Felipe Contreras
2021-07-19 8:33 ` Jeff King
2021-07-19 10:41 ` Patrick Steinhardt
2021-07-19 10:52 ` Jeff King
2021-07-19 18:40 ` Junio C Hamano
2021-07-19 19:57 ` Felipe Contreras
2021-07-20 6:31 ` Patrick Steinhardt
2021-07-20 7:21 ` Felipe Contreras
2021-07-20 6:32 ` [PATCH] t0000: fix test if run with TEST_OUTPUT_DIRECTORY Patrick Steinhardt
2021-07-20 7:11 ` Jeff King
2021-07-20 16:21 ` Junio C Hamano
2021-07-20 7:24 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bdd27b7-cbe1-6952-eca0-f6fcecdaec8c@gmail.com \
--to=stolee@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).