From: Felipe Contreras <felipe.contreras@gmail.com>
To: Patrick Steinhardt <ps@pks.im>,
Felipe Contreras <felipe.contreras@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jul 2021, #03; Tue, 13)
Date: Tue, 20 Jul 2021 02:21:16 -0500 [thread overview]
Message-ID: <60f6796c18a4d_14a799208fb@natae.notmuch> (raw)
In-Reply-To: <YPZtxy1/742YlrlK@ncase>
Patrick Steinhardt wrote:
> On Mon, Jul 19, 2021 at 02:57:23PM -0500, Felipe Contreras wrote:
> > Junio C Hamano wrote:
> > > Patrick Steinhardt <ps@pks.im> writes:
> > >
> > > > On Mon, Jul 19, 2021 at 04:33:54AM -0400, Jeff King wrote:
> > > >> On Mon, Jul 19, 2021 at 09:35:36AM +0200, Patrick Steinhardt wrote:
> > > >>
> > > >> > On Tue, Jul 13, 2021 at 06:07:12PM -0700, Junio C Hamano wrote:
> > > >> > [snip]
> > > >> > > * ps/perf-with-separate-output-directory (2021-07-02) 1 commit
> > > >> > > - perf: fix when running with TEST_OUTPUT_DIRECTORY
> > > >> > >
> > > >> > > Test update.
> > > >> > >
> > > >> > > What's the status of this one?
> > > >> >
> > > >> > From my point of view this is ready, but it's still missing reviews so
> > > >> > far. The lack of interest seems to indicate that nobody has hit the
> > > >> > issue so far, and I wonder why that is. Am I the only one who sets
> > > >> > TEST_OUTPUT_DIRECTORY to a tmpfs directory in his config.mak to speed up
> > > >> > tests?
> > > >>
> > > >> I had marked it to look at, but just hadn't gotten around to it. I just
> > > >> gave it a review (but the upshot is that it looks fine to me).
> > > >>
> > > >> I don't set TEST_OUTPUT_DIRECTORY myself; instead I do:
> > > >>
> > > >> GIT_TEST_OPTS = --root=/path/to/tmpfs
> > > >>
> > > >> TBH, I had never really considered using TEST_OUTPUT_DIRECTORY for this
> > > >> (--root predates it, and was written explicitly for the tmpfs case). But
> > > >> I also think --root is more convenient:
> > > >>
> > > >> - "make test" will run in the tmpfs for speed, but "./t1234-foo.sh -i"
> > > >> will run locally, which makes it easy to "cd" in to inspect the
> > > >> result
> > > >>
> > > >> - likewise, I find accessing the results in t/test-results/*.out a
> > > >> little more convenient
> > > >>
> > > >> But all of that is preference. I don't think you're wrong to use
> > > >> TEST_OUTPUT_DIRECTORY this way, but the above points might be
> > > >> interesting to you.
> > > >
> > > > It is, thanks a lot for the hint. But given your first point about
> > > > direct execution, this in fact makes me want TEST_OUTPUT_DIRECTORY in
> > > > contrast to `--root=/path/to/tmpfs`: especially in the context of perf
> > > > tests, I never run all of them together given that it takes such a long
> > > > time. So I instead either run them directly or via the `./run` script,
> > > > and in both cases I definitely want to have them in tmpfs given that
> > > > there's a lot of disk churn if you're using biggish repos.
> > > >
> > > > Patrick
> > >
> > > Thanks, all. Let me mark the patch for 'next'.
> >
> > OK, if you don't care that TEST_OUTPUT_DIRECTORY is broken, so be it.
>
> I just think we shouldn't strip away features if we should instead look
> at why the testcase is broken and how to fix the root cause.
I mean, we didn't really strip away any features, you just happened to add
one feature at the same time the fix was proposed.
> I'll send a patch in a minute which fixes the testcase without
> dropping support for TEST_OUTPUT_DIRECTORY.
OK. You mean without breaking functonality that is flying.
--
Felipe Contreras
next prev parent reply other threads:[~2021-07-20 7:21 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 1:07 What's cooking in git.git (Jul 2021, #03; Tue, 13) Junio C Hamano
2021-07-14 2:16 ` Eric Sunshine
2021-07-14 16:30 ` Junio C Hamano
2021-07-14 22:39 ` Eric Sunshine
2021-07-14 22:44 ` Junio C Hamano
2021-07-14 8:42 ` Han-Wen Nienhuys
2021-07-14 11:53 ` Ævar Arnfjörð Bjarmason
2021-07-14 11:54 ` Ævar Arnfjörð Bjarmason
2021-07-14 17:28 ` Junio C Hamano
2021-07-14 13:11 ` Derrick Stolee
2021-07-14 14:32 ` Ævar Arnfjörð Bjarmason
2021-07-15 16:25 ` [PATCH] CodingGuidelines: recommend gender-neutral description Junio C Hamano
2021-07-15 16:35 ` Eric Sunshine
2021-07-15 16:47 ` Taylor Blau
2021-07-15 18:02 ` Junio C Hamano
2021-07-16 21:25 ` Felipe Contreras
2021-07-15 17:27 ` Derrick Stolee
2021-07-16 15:11 ` Johannes Schindelin
2021-07-16 21:22 ` Felipe Contreras
2021-07-16 18:41 ` [PATCH v2] " Junio C Hamano
2021-07-16 19:05 ` Derrick Stolee
2021-07-16 19:11 ` Ævar Arnfjörð Bjarmason
2021-07-16 19:50 ` Junio C Hamano
2021-07-16 21:14 ` Felipe Contreras
2021-08-12 8:35 ` [PATCH] " Bagas Sanjaya
2021-07-14 20:11 ` What's cooking in git.git (Jul 2021, #03; Tue, 13) Taylor Blau
2021-07-19 7:35 ` Patrick Steinhardt
2021-07-19 7:53 ` Felipe Contreras
2021-07-19 8:35 ` Jeff King
2021-07-19 10:42 ` Felipe Contreras
2021-07-19 10:56 ` Patrick Steinhardt
2021-07-19 11:25 ` Felipe Contreras
2021-07-19 8:33 ` Jeff King
2021-07-19 10:41 ` Patrick Steinhardt
2021-07-19 10:52 ` Jeff King
2021-07-19 18:40 ` Junio C Hamano
2021-07-19 19:57 ` Felipe Contreras
2021-07-20 6:31 ` Patrick Steinhardt
2021-07-20 7:21 ` Felipe Contreras [this message]
2021-07-20 6:32 ` [PATCH] t0000: fix test if run with TEST_OUTPUT_DIRECTORY Patrick Steinhardt
2021-07-20 7:11 ` Jeff King
2021-07-20 16:21 ` Junio C Hamano
2021-07-20 7:24 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60f6796c18a4d_14a799208fb@natae.notmuch \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).