From: "Eric Huber via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Paul Mackerras <paulus@samba.org>,
Junio C Hamano <gitster@pobox.com>,
Eric Huber <echuber2@illinois.edu>
Subject: [PATCH 1/1] gitk: Preserve window dimensions on exit when not using ttk themes
Date: Tue, 15 Oct 2019 00:13:16 +0000 [thread overview]
Message-ID: <364976a833e33696e983bbdd9c1e7974480c1397.1571098396.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.389.git.1571098396.gitgitgadget@gmail.com>
From: Eric Huber <echuber2@illinois.edu>
Bug was: gitk would overwrite the botwidth setting in .gitk with
a nonsense value when not using tk themes. I'm not sure if this
is the right fix or not but it seems to work. Moving the affected
line within the conditional results in the expected behavior.
Signed-off-by: Eric Huber <echuber2@illinois.edu>
---
gitk-git/gitk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index abe4805ade..4846f2a983 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -2526,9 +2526,9 @@ proc makewindow {} {
bind %W <Map> {}
%W sashpos 0 $::geometry(botwidth)
}
+ bind .pwbottom <Configure> {resizecdetpanes %W %w}
}
-
- bind .pwbottom <Configure> {resizecdetpanes %W %w}
+
pack .ctop -fill both -expand 1
bindall <1> {selcanvline %W %x %y}
#bindall <B1-Motion> {selcanvline %W %x %y}
--
gitgitgadget
next prev parent reply other threads:[~2019-10-15 0:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 0:13 [PATCH 0/1] gitk: Preserve window dimensions on exit when not using ttk themes Eric Huber via GitGitGadget
2019-10-15 0:13 ` Eric Huber via GitGitGadget [this message]
2019-12-15 5:33 ` [PATCH 1/1] " Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=364976a833e33696e983bbdd9c1e7974480c1397.1571098396.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=echuber2@illinois.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).