* [PATCH 0/1] gitk: Preserve window dimensions on exit when not using ttk themes
@ 2019-10-15 0:13 Eric Huber via GitGitGadget
2019-10-15 0:13 ` [PATCH 1/1] " Eric Huber via GitGitGadget
0 siblings, 1 reply; 3+ messages in thread
From: Eric Huber via GitGitGadget @ 2019-10-15 0:13 UTC (permalink / raw)
To: git; +Cc: Paul Mackerras, Junio C Hamano
This fix is intended to let gitk preserve the window pane dimensions
regardless of whether ttk is enabled or not. I'm not an expert on Tcl/Tk but
as far as I can tell, this edit works and doesn't cause problems. Please
double-check what I did.
Eric Huber (1):
gitk: Preserve window dimensions on exit when not using ttk themes
gitk-git/gitk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
base-commit: 70bf0b755af4d1e66da25b7805cac0e481a082e4
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-389%2Fechuber2%2Fpatch-1-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-389/echuber2/patch-1-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/389
--
gitgitgadget
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] gitk: Preserve window dimensions on exit when not using ttk themes
2019-10-15 0:13 [PATCH 0/1] gitk: Preserve window dimensions on exit when not using ttk themes Eric Huber via GitGitGadget
@ 2019-10-15 0:13 ` Eric Huber via GitGitGadget
2019-12-15 5:33 ` Paul Mackerras
0 siblings, 1 reply; 3+ messages in thread
From: Eric Huber via GitGitGadget @ 2019-10-15 0:13 UTC (permalink / raw)
To: git; +Cc: Paul Mackerras, Junio C Hamano, Eric Huber
From: Eric Huber <echuber2@illinois.edu>
Bug was: gitk would overwrite the botwidth setting in .gitk with
a nonsense value when not using tk themes. I'm not sure if this
is the right fix or not but it seems to work. Moving the affected
line within the conditional results in the expected behavior.
Signed-off-by: Eric Huber <echuber2@illinois.edu>
---
gitk-git/gitk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index abe4805ade..4846f2a983 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -2526,9 +2526,9 @@ proc makewindow {} {
bind %W <Map> {}
%W sashpos 0 $::geometry(botwidth)
}
+ bind .pwbottom <Configure> {resizecdetpanes %W %w}
}
-
- bind .pwbottom <Configure> {resizecdetpanes %W %w}
+
pack .ctop -fill both -expand 1
bindall <1> {selcanvline %W %x %y}
#bindall <B1-Motion> {selcanvline %W %x %y}
--
gitgitgadget
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] gitk: Preserve window dimensions on exit when not using ttk themes
2019-10-15 0:13 ` [PATCH 1/1] " Eric Huber via GitGitGadget
@ 2019-12-15 5:33 ` Paul Mackerras
0 siblings, 0 replies; 3+ messages in thread
From: Paul Mackerras @ 2019-12-15 5:33 UTC (permalink / raw)
To: Eric Huber via GitGitGadget; +Cc: git, Junio C Hamano, Eric Huber
On Tue, Oct 15, 2019 at 12:13:16AM +0000, Eric Huber via GitGitGadget wrote:
> From: Eric Huber <echuber2@illinois.edu>
>
> Bug was: gitk would overwrite the botwidth setting in .gitk with
> a nonsense value when not using tk themes. I'm not sure if this
> is the right fix or not but it seems to work. Moving the affected
> line within the conditional results in the expected behavior.
>
> Signed-off-by: Eric Huber <echuber2@illinois.edu>
Thanks, patch applied.
Paul.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-15 5:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-15 0:13 [PATCH 0/1] gitk: Preserve window dimensions on exit when not using ttk themes Eric Huber via GitGitGadget
2019-10-15 0:13 ` [PATCH 1/1] " Eric Huber via GitGitGadget
2019-12-15 5:33 ` Paul Mackerras
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).