From: "Ping Yin" <pkufranky@gmail.com>
To: "Johannes Sixt" <j.sixt@viscovery.net>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH v2 2/4] builtin-status: submodule summary support
Date: Fri, 14 Mar 2008 02:01:06 +0800 [thread overview]
Message-ID: <46dff0320803131101g62c16db2wf999c851672a8e0@mail.gmail.com> (raw)
In-Reply-To: <47D935FE.8010107@viscovery.net>
On Thu, Mar 13, 2008 at 10:11 PM, Johannes Sixt <j.sixt@viscovery.net> wrote:
> Ping Yin schrieb:
>
> > wt_status_print_changed(s);
> > + // must flush s->fp since following call will write to s->fp in a child process
> > + fflush(s->fp);
> > + wt_status_print_submodule_summary(s);
> > wt_status_print_untracked(s);
>
> But then we don't need the fflush() here. Right?
>
You are right.
diff --git a/wt-status.c b/wt-status.c
index 2f47e36..468c14c 100644
--- a/wt-status.c
+++ b/wt-status.c
@@ -352,8 +352,6 @@ void wt_status_print(struct wt_status *s)
}
wt_status_print_changed(s);
- // must flush s->fp since following call will write to s->fp
in a child process
- fflush(s->fp);
wt_status_print_submodule_summary(s);
wt_status_print_untracked(s)
--
Ping Yin
next prev parent reply other threads:[~2008-03-13 18:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-13 13:48 builtin-status submodule summary Ping Yin
2008-03-13 13:48 ` [PATCH v2 1/4] git-submodule summary: --for-status option Ping Yin
2008-03-13 13:48 ` [PATCH v2 2/4] builtin-status: submodule summary support Ping Yin
2008-03-13 13:48 ` [PATCH v2 3/4] builtin-status: configurable submodule summary size Ping Yin
2008-03-13 13:48 ` [PATCH v2 4/4] buitin-status: Add tests for submodule summary Ping Yin
2008-03-13 14:21 ` Johannes Sixt
2008-03-13 18:04 ` Junio C Hamano
2008-03-13 18:14 ` Ping Yin
2008-03-13 18:09 ` Ping Yin
2008-03-13 14:15 ` [PATCH v2 3/4] builtin-status: configurable submodule summary size Johannes Sixt
2008-03-13 14:11 ` [PATCH v2 2/4] builtin-status: submodule summary support Johannes Sixt
2008-03-13 18:01 ` Ping Yin [this message]
2008-03-14 14:30 ` builtin-status submodule summary Ping Yin
2008-03-14 16:39 ` Junio C Hamano
2008-03-14 17:45 ` Ping Yin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46dff0320803131101g62c16db2wf999c851672a8e0@mail.gmail.com \
--to=pkufranky@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).