From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>,
Junio C Hamano <gitster@pobox.com>
Cc: GIT Mailing-list <git@vger.kernel.org>,
Trygve Aaberge <trygveaa@gmail.com>
Subject: Re: [PATCH] bisect--helper: use BISECT_TERMS in 'bisect skip' command
Date: Sun, 25 Apr 2021 15:16:44 +0700 [thread overview]
Message-ID: <473a11db-cbb5-58b9-b05d-cab2072d5d2f@gmail.com> (raw)
In-Reply-To: <fd40e12f-9649-1327-4bdb-dce5b5eed619@ramsayjones.plus.com>
On 25/04/21 07.18, Ramsay Jones wrote:
>
> This patch was created directly on top of commit e4c7b33747 and tested
> with the test from Bagas Sanjaya [1] (ie the second version of the
> stand-alone test file t6031-*.sh, rather than the newer patch that
> adds the test to t6030-*.sh). I applied this patch to the current
> master branch (@311531c9de55) and it also passed the test in [1].
I have just sent v2 of t6030 version of my test [1]. Please test
this patch against that v2 test. And if the test passes (breakage vanished),
please update the test by do instructions in the FIXME comment lines of [1].
> @@ -1129,6 +1129,7 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
> break;
> case BISECT_SKIP:
> set_terms(&terms, "bad", "good");
> + get_terms(&terms);
I'm not fluent in C, but I read these lines above as "ok, we set terms from
&terms, bad and good as fallback in case the reference is empty; then we get these
terms from the reference". Wouldn't it makes sense if we can say "get the terms
from &terms" first, then "set the terms from the reference, if empty use bad
and good as fallback"?
[1]: https://lore.kernel.org/git/20210425080508.154159-1-bagasdotme@gmail.com/
--
An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2021-04-25 8:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-25 0:18 [PATCH] bisect--helper: use BISECT_TERMS in 'bisect skip' command Ramsay Jones
2021-04-25 8:16 ` Bagas Sanjaya [this message]
2021-04-26 7:06 ` Christian Couder
2021-04-28 4:09 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473a11db-cbb5-58b9-b05d-cab2072d5d2f@gmail.com \
--to=bagasdotme@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsayjones.plus.com \
--cc=trygveaa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).