From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Christian Couder <christian.couder@gmail.com>,
Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>,
Trygve Aaberge <trygveaa@gmail.com>
Subject: Re: [PATCH] bisect--helper: use BISECT_TERMS in 'bisect skip' command
Date: Wed, 28 Apr 2021 11:09:20 +0700 [thread overview]
Message-ID: <ffd80d10-9939-d31c-324d-3e32c37d2eaf@gmail.com> (raw)
In-Reply-To: <CAP8UFD3hOqeF04Xdjn-o2FShuTPQ9ZUEVCWnhfzCqV6MtbvU4g@mail.gmail.com>
On 26/04/21 14.06, Christian Couder wrote:
> Thanks Bagas for your test! I will take a look at it soon.
>
> My opinion is that it would be best if both patches (Ramsay's and
> Bagas') were in the same patch series or even perhaps in the same
> commit. If you prefer separate patches, maybe the first one could be
> Ramsay's, and the second one Bagas' where indeed the instructions to
> replace test_expect_failure with test_expect_success have been
> followed.
>
OK. Review ping
> It might not be the best API for this (or the set_terms() and
> get_terms() function could perhaps have better names), but anyway the
> current situation is that set_terms(&terms, "bad", "good") is setting
> the current terms to "bad"/"good" which is the default, and then
> get_terms(&terms) is reading the terms stored in the BISECT_TERMS file
> and using that to set the current terms. Also if the BISECT_TERMS file
> doesn't exist, then get_terms(&terms) is doing nothing. So it seems to
> me that Ramsay's patch is doing the right thing.
>
> If get_terms(&terms) was used before set_terms(&terms, "bad", "good"),
> then the current terms would always be "bad"/"good" even if the
> BISECT_TERMS file contains valid terms different from "bad"/"good".
>
OK, thanks for the explanation.
--
An old man doll... just what I always wanted! - Clara
prev parent reply other threads:[~2021-04-28 4:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-25 0:18 [PATCH] bisect--helper: use BISECT_TERMS in 'bisect skip' command Ramsay Jones
2021-04-25 8:16 ` Bagas Sanjaya
2021-04-26 7:06 ` Christian Couder
2021-04-28 4:09 ` Bagas Sanjaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffd80d10-9939-d31c-324d-3e32c37d2eaf@gmail.com \
--to=bagasdotme@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsayjones.plus.com \
--cc=trygveaa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).