git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* git -c var=val not taken into account by git config?
@ 2012-05-07 23:16 Daniel Villeneuve
  2012-05-08  9:16 ` Jeff King
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Villeneuve @ 2012-05-07 23:16 UTC (permalink / raw)
  To: git

Hi,

Testing color configuration via scripting, I tried the following command:

git -c color.diff=always config --get-colorbool diff false

on a repository with color.diff=auto.

I'd expect "true" as output, but got "false".  "git diff" works as 
expected though.  Is this an exception for "git config"?

Using git version 1.7.10.1.
--
Daniel Villeneuve

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: git -c var=val not taken into account by git config?
  2012-05-07 23:16 git -c var=val not taken into account by git config? Daniel Villeneuve
@ 2012-05-08  9:16 ` Jeff King
  2012-05-08 12:56   ` Daniel Villeneuve
  0 siblings, 1 reply; 3+ messages in thread
From: Jeff King @ 2012-05-08  9:16 UTC (permalink / raw)
  To: Daniel Villeneuve; +Cc: git

On Mon, May 07, 2012 at 07:16:51PM -0400, Daniel Villeneuve wrote:

> Testing color configuration via scripting, I tried the following command:
> 
> git -c color.diff=always config --get-colorbool diff false
> 
> on a repository with color.diff=auto.
> 
> I'd expect "true" as output, but got "false".  "git diff" works as
> expected though.  Is this an exception for "git config"?

I think you meant "--get-colorbool color.diff"; the fact that you are
getting a colorbool does not automatically place the name inside the
color.* section.

With that change, it seems to work as expected.

-Peff

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: git -c var=val not taken into account by git config?
  2012-05-08  9:16 ` Jeff King
@ 2012-05-08 12:56   ` Daniel Villeneuve
  0 siblings, 0 replies; 3+ messages in thread
From: Daniel Villeneuve @ 2012-05-08 12:56 UTC (permalink / raw)
  To: Jeff King; +Cc: git

On 08/05/12 05:16 AM, Jeff King wrote:
> On Mon, May 07, 2012 at 07:16:51PM -0400, Daniel Villeneuve wrote:
>
>> Testing color configuration via scripting, I tried the following command:
>>
>> git -c color.diff=always config --get-colorbool diff false
>>
>> on a repository with color.diff=auto.
>>
>> I'd expect "true" as output, but got "false".  "git diff" works as
>> expected though.  Is this an exception for "git config"?
> I think you meant "--get-colorbool color.diff"; the fact that you are
> getting a colorbool does not automatically place the name inside the
> color.* section.
>
> With that change, it seems to work as expected.
>
> -Peff
>
Indeed, and the example was mentioning "color.diff".  My error.  Giving 
just "diff", I was getting results from color.ui instead.

Regards,
--
Daniel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-05-08 12:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-07 23:16 git -c var=val not taken into account by git config? Daniel Villeneuve
2012-05-08  9:16 ` Jeff King
2012-05-08 12:56   ` Daniel Villeneuve

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).