git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vegard Nossum <vegard.nossum@oracle.com>
To: Junio C Hamano <gitster@pobox.com>,
	Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: git@vger.kernel.org
Subject: Re: Making GitGitGadget conversion lossless
Date: Wed, 26 Feb 2020 22:32:09 +0100	[thread overview]
Message-ID: <51155ef5-e301-2f5d-263e-184b9ab0979d@oracle.com> (raw)
In-Reply-To: <xmqq5zfthxlw.fsf@gitster-ct.c.googlers.com>

On 2/26/20 10:01 PM, Junio C Hamano wrote:
> As I said already, I do not think that the desire to get the
> bit-for-bit identical commit is compatible with the idea to discuss
> e-mailed patches---the pieces of patch e-mail will become "you may
> look at them, you may apply them, but it is no use to comment on
> them to get them improved".  So, I dunno.

For me, at least, the goal was to be able to store previous patch
submissions in git (even if it is not merged into the main tree) so
that you can use git and all its tools (diff, log, blame, grep, notes,
etc.) to browse previous versions and browse discussions _and_ use the
SHA1 as a stable identifier for a specific submission.

The point of having the stable identifier is so that the submitter can
take comments into account and resubmit their patchset while still
keeping a (stable, universal, unambiguous) reference to their previous
submission.

I don't see the incompatibility at all. The whole point was that the
current email workflow used by Linux and git (that includes discussion,
feedback, and revision) _does not need to change_.


Vegard

  reply	other threads:[~2020-02-26 21:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-26 20:09 Making GitGitGadget conversion lossless Konstantin Ryabitsev
2020-02-26 21:01 ` Junio C Hamano
2020-02-26 21:32   ` Vegard Nossum [this message]
2020-02-26 21:35   ` Konstantin Ryabitsev
2020-02-26 22:27     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51155ef5-e301-2f5d-263e-184b9ab0979d@oracle.com \
    --to=vegard.nossum@oracle.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=konstantin@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).