git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: git@vger.kernel.org, vegard.nossum@oracle.com
Subject: Re: Making GitGitGadget conversion lossless
Date: Wed, 26 Feb 2020 13:01:15 -0800	[thread overview]
Message-ID: <xmqq5zfthxlw.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20200226200929.z4aej74ohbkgcdza@chatter.i7.local> (Konstantin Ryabitsev's message of "Wed, 26 Feb 2020 15:09:29 -0500")

Konstantin Ryabitsev <konstantin@linuxfoundation.org> writes:

> - parent/tree hashes

Isn't this already available by recording the base-commit
information?

> - author/committer information
> - cryptographic attestation (gpgsig)

I think you are aiming to come up with bit-for-bit identical commit
the sender had, and I would imagine that the easiest and least
disruptive way to do so is to add a compressed and ascii-armored
copy of "git cat-file commit" output of the original commit after
the "---" line before the diff/diffstat of the e-mailed patch.  The
receiving end can then act on it when given some option by

 - first recover the contents of the commit object (call it #1);
 - learn the parent commit(s) and check out the tree;
 - apply the patch in the remainder of the patch e-mail to the tree;
 - make sure that the result of patch application gives the tree object
   recorded in #1;
 - run "hash-object -t commit -w" over #1 that gives you a commit
   object that is bit-for-bit identical.

As I said already, I do not think that the desire to get the
bit-for-bit identical commit is compatible with the idea to discuss
e-mailed patches---the pieces of patch e-mail will become "you may
look at them, you may apply them, but it is no use to comment on
them to get them improved".  So, I dunno.

  reply	other threads:[~2020-02-26 21:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-26 20:09 Making GitGitGadget conversion lossless Konstantin Ryabitsev
2020-02-26 21:01 ` Junio C Hamano [this message]
2020-02-26 21:32   ` Vegard Nossum
2020-02-26 21:35   ` Konstantin Ryabitsev
2020-02-26 22:27     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5zfthxlw.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=konstantin@linuxfoundation.org \
    --cc=vegard.nossum@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).