From: Felipe Contreras <felipe.contreras@gmail.com> To: Junio C Hamano <gitster@pobox.com>, Felipe Contreras <felipe.contreras@gmail.com> Cc: git@vger.kernel.org, "Jeff King" <peff@peff.net>, "Martin Ågren" <martin.agren@gmail.com>, "brian m . carlson" <sandals@crustytoothpaste.net> Subject: Re: [PATCH 4/8] doc: simplify the handling of interruptions Date: Thu, 13 May 2021 01:10:18 -0500 [thread overview] Message-ID: <609cc2ca7cf26_1e7820868@natae.notmuch> (raw) In-Reply-To: <xmqqmtszb47p.fsf@gitster.g> Junio C Hamano wrote: > Felipe Contreras <felipe.contreras@gmail.com> writes: > > > +"${args[@]}" -o "$out" "$1" || > > +{ rm -f "$out"; false; } > > It would be so nice if this worked, but here is what I saw in a > quick-and-dirty experiment: > > $ f hoi || rm hoi ;# wait a bit and hit ^C > > So, I suspect it unfortunately may not work well. That's because the interrupt signal is not caught. This works: sh -c 'echo foo >"$1" && trap "exit 1" INT && sleep 20' test hoi || rm hoi And so does this: #!/bin/sh ruby - hoi <<EOF || rm hoi File.write(ARGV[0], 'foo') begin sleep(10) rescue Exception exit(1) end EOF Both asciidoc and asciidoctor trap the signal. > We need to get 2/8 redone without bash-ism, Yes, if we agree this approach is indeed desirable I can do that. Cheers. -- Felipe Contreras
next prev parent reply other threads:[~2021-05-13 6:10 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-12 22:27 [PATCH 0/8] doc: asciidoc cleanups Felipe Contreras 2021-05-12 22:27 ` [PATCH 1/8] doc: standardize asciidoc calls Felipe Contreras 2021-05-12 22:27 ` [PATCH 2/8] doc: add an asciidoc helper Felipe Contreras 2021-05-13 15:17 ` Ævar Arnfjörð Bjarmason 2021-05-13 19:33 ` Felipe Contreras 2021-05-13 21:43 ` Junio C Hamano 2021-05-12 22:27 ` [PATCH 3/8] doc: disable asciidoc-helper for asciidoctor Felipe Contreras 2021-05-12 22:27 ` [PATCH 4/8] doc: simplify the handling of interruptions Felipe Contreras 2021-05-13 5:19 ` Junio C Hamano 2021-05-13 6:10 ` Felipe Contreras [this message] 2021-05-12 22:28 ` [PATCH 5/8] doc: remove redundant rm Felipe Contreras 2021-05-13 15:22 ` Ævar Arnfjörð Bjarmason 2021-05-13 18:58 ` Felipe Contreras 2021-05-12 22:28 ` [PATCH 6/8] doc: refactor common dependencies Felipe Contreras 2021-05-12 22:28 ` [PATCH 7/8] doc: improve asciidoc dependencies Felipe Contreras 2021-05-13 17:43 ` Martin Ågren 2021-05-12 22:28 ` [PATCH 8/8] doc: join xml and man rules Felipe Contreras 2021-05-13 11:02 ` Martin Ågren 2021-05-13 11:15 ` Felipe Contreras
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=609cc2ca7cf26_1e7820868@natae.notmuch \ --to=felipe.contreras@gmail.com \ --cc=git@vger.kernel.org \ --cc=gitster@pobox.com \ --cc=martin.agren@gmail.com \ --cc=peff@peff.net \ --cc=sandals@crustytoothpaste.net \ --subject='Re: [PATCH 4/8] doc: simplify the handling of interruptions' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).