* [PATCH] diff.c: diff.renamelimit => diff.renameLimit in message
@ 2013-03-21 19:53 Max Nanasy
2013-03-21 20:43 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Max Nanasy @ 2013-03-21 19:53 UTC (permalink / raw)
To: git
In the warning message printed when rename or unmodified copy
detection was skipped due to too many files, change "diff.renamelimit"
to "diff.renameLimit", in order to make it consistent with git
documentation, which consistently uses "diff.renameLimit".
Signed-off-by: Max Nanasy <max.nanasy@gmail.com>
---
diff.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/diff.c b/diff.c
index 156fec4..052974e 100644
--- a/diff.c
+++ b/diff.c
@@ -4662,7 +4662,7 @@ int diff_result_code(struct diff_options *opt, int status)
{
int result = 0;
- diff_warn_rename_limit("diff.renamelimit",
+ diff_warn_rename_limit("diff.renameLimit",
opt->needed_rename_limit,
opt->degraded_cc_to_c);
if (!DIFF_OPT_TST(opt, EXIT_WITH_STATUS) &&
--
1.8.1.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] diff.c: diff.renamelimit => diff.renameLimit in message
2013-03-21 19:53 [PATCH] diff.c: diff.renamelimit => diff.renameLimit in message Max Nanasy
@ 2013-03-21 20:43 ` Junio C Hamano
2013-03-21 22:14 ` [PATCH v2] " Max Nanasy
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2013-03-21 20:43 UTC (permalink / raw)
To: Max Nanasy; +Cc: git
Max Nanasy <max.nanasy@gmail.com> writes:
> In the warning message printed when rename or unmodified copy
> detection was skipped due to too many files, change "diff.renamelimit"
> to "diff.renameLimit", in order to make it consistent with git
> documentation, which consistently uses "diff.renameLimit".
>
> Signed-off-by: Max Nanasy <max.nanasy@gmail.com>
> ---
I "git grep"ed around and it tells me that this is the only such
place. Thanks.
The patch is severely whitespace damaged. If you plan to keep
contributing to Git, I'd like to make sure that your mail toolchain
is sane, so that we do not have to keep hand-adjusting patches
submitted by you before applying.
> diff.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/diff.c b/diff.c
> index 156fec4..052974e 100644
> --- a/diff.c
> +++ b/diff.c
> @@ -4662,7 +4662,7 @@ int diff_result_code(struct diff_options *opt, int status)
> {
> int result = 0;
>
> - diff_warn_rename_limit("diff.renamelimit",
> + diff_warn_rename_limit("diff.renameLimit",
> opt->needed_rename_limit,
> opt->degraded_cc_to_c);
> if (!DIFF_OPT_TST(opt, EXIT_WITH_STATUS) &&
> --
> 1.8.1.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] diff.c: diff.renamelimit => diff.renameLimit in message
2013-03-21 20:43 ` Junio C Hamano
@ 2013-03-21 22:14 ` Max Nanasy
0 siblings, 0 replies; 3+ messages in thread
From: Max Nanasy @ 2013-03-21 22:14 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, Max Nanasy
In the warning message printed when rename or unmodified copy
detection was skipped due to too many files, change "diff.renamelimit"
to "diff.renameLimit", in order to make it consistent with git
documentation, which consistently uses "diff.renameLimit".
Signed-off-by: Max Nanasy <max.nanasy@gmail.com>
---
Junio C Hamano <gitster <at> pobox.com> writes:
>
> The patch is severely whitespace damaged. If you plan to keep
> contributing to Git, I'd like to make sure that your mail toolchain
> is sane, so that we do not have to keep hand-adjusting patches
> submitted by you before applying.
>
I composed the first patch through the GMail web interface, which converted
tabs to spaces. I'm retrying this one through git send-email.
diff.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/diff.c b/diff.c
index 156fec4..052974e 100644
--- a/diff.c
+++ b/diff.c
@@ -4662,7 +4662,7 @@ int diff_result_code(struct diff_options *opt, int status)
{
int result = 0;
- diff_warn_rename_limit("diff.renamelimit",
+ diff_warn_rename_limit("diff.renameLimit",
opt->needed_rename_limit,
opt->degraded_cc_to_c);
if (!DIFF_OPT_TST(opt, EXIT_WITH_STATUS) &&
--
1.8.1.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-21 22:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-21 19:53 [PATCH] diff.c: diff.renamelimit => diff.renameLimit in message Max Nanasy
2013-03-21 20:43 ` Junio C Hamano
2013-03-21 22:14 ` [PATCH v2] " Max Nanasy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).