From: Junio C Hamano <gitster@pobox.com>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: "Torsten Bögershausen" <tboegi@web.de>,
git@vger.kernel.org, j6t@kdbg.org
Subject: Re: [RFC] test-lib.sh: No POSIXPERM for cygwin
Date: Thu, 07 Feb 2013 11:35:17 -0800 [thread overview]
Message-ID: <7vd2wb7w96.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <5113F1B1.3010102@ramsay1.demon.co.uk> (Ramsay Jones's message of "Thu, 07 Feb 2013 18:25:53 +0000")
Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
> Torsten Bögershausen wrote:
>> t0070 and t1301 fail when running the test suite under cygwin.
>> Skip the failing tests by unsetting POSIXPERM.
>
> t1301 does not fail for me. (WIN XP (SP3) on NTFS)
Others run Cygwin with vfat or some other filesystem, and some of
them do not cope will with POSIXPERM, perhaps?
Not having POSIXPERM by default for Cygwin may be a saner default
than having one, if we have to pick one.
It may be debatable to have this default as platform attribute,
though.
>> Signed-off-by: Torsten Bögershausen <tboegi@web.de>
>> ---
>> t/test-lib.sh | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/t/test-lib.sh b/t/test-lib.sh
>> index 1a6c4ab..94b097e 100644
>> --- a/t/test-lib.sh
>> +++ b/t/test-lib.sh
>> @@ -669,7 +669,6 @@ case $(uname -s) in
>> test_set_prereq SED_STRIPS_CR
>> ;;
>> *CYGWIN*)
>> - test_set_prereq POSIXPERM
>> test_set_prereq EXECKEEPSPID
>> test_set_prereq NOT_MINGW
>> test_set_prereq SED_STRIPS_CR
>>
>
> So, I'm not in favour of this, FWIW.
>
> ATB,
> Ramsay Jones
next prev parent reply other threads:[~2013-02-07 19:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-27 14:57 [RFC] test-lib.sh: No POSIXPERM for cygwin Torsten Bögershausen
2013-02-06 9:34 ` Erik Faye-Lund
2013-02-06 20:16 ` Torsten Bögershausen
2013-02-07 18:25 ` Ramsay Jones
2013-02-07 19:35 ` Junio C Hamano [this message]
2013-02-08 6:08 ` Torsten Bögershausen
2013-03-19 19:49 Torsten Bögershausen
2013-03-19 21:03 ` Junio C Hamano
2013-03-19 21:10 ` Junio C Hamano
2013-03-23 12:40 Torsten Bögershausen
2013-03-24 2:49 ` Eric Sunshine
2013-03-25 15:53 ` Torsten Bögershausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd2wb7w96.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=ramsay@ramsay1.demon.co.uk \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).