git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: Junio C Hamano <gitster@pobox.com>,
	j6t@kdbg.org, Git List <git@vger.kernel.org>,
	ramsay@ramsay1.demon.co.uk
Subject: Re: [RFC] test-lib.sh: No POSIXPERM for cygwin
Date: Sat, 23 Mar 2013 22:49:17 -0400	[thread overview]
Message-ID: <CAPig+cR0HdQq4P=MWg7xkFLMzNimitty_Bj7mVx+w3eoi9bZ3g@mail.gmail.com> (raw)
In-Reply-To: <201303231340.29687.tboegi@web.de>

On Sat, Mar 23, 2013 at 8:40 AM, Torsten Bögershausen <tboegi@web.de> wrote:
> Subject: [PATCH] Make core.sharedRepository work under cygwin 1.7
>
> When core.sharedRepository is used, set_shared_perm() in path.c
> needs lstat() to return the correct POSIX permissions.
>
> The default for cygwin is core.ignoreCygwinFSTricks = false, which
> means that the fast implementation in do_stat() is used instead of lstat().
>
> lstat() under cygwin uses the Windows security model to implement
> POSIX-like permissions.
> The user, group or everyone bits can be set individually.
>
> do_stat() simplifes the file permission bits, and may return a wrong value:
> The read-only attribute of a file is used to calculate
> the permissions, resulting in either rw-r--r-- or r--r--r--
>
> One effect of the simplified do_stat() is that t1301 failes.

s/failes/fails/

> Add a function cygwin_get_st_mode_bits() which returns the POSIX permissions.
> When not compiling for cygwin, true_mode_bits() in path.c is used.

  reply	other threads:[~2013-03-24  2:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-23 12:40 [RFC] test-lib.sh: No POSIXPERM for cygwin Torsten Bögershausen
2013-03-24  2:49 ` Eric Sunshine [this message]
2013-03-25 15:53   ` Torsten Bögershausen
  -- strict thread matches above, loose matches on Subject: below --
2013-03-19 19:49 Torsten Bögershausen
2013-03-19 21:03 ` Junio C Hamano
2013-03-19 21:10   ` Junio C Hamano
2013-01-27 14:57 Torsten Bögershausen
2013-02-06  9:34 ` Erik Faye-Lund
2013-02-06 20:16   ` Torsten Bögershausen
2013-02-07 18:25 ` Ramsay Jones
2013-02-07 19:35   ` Junio C Hamano
2013-02-08  6:08     ` Torsten Bögershausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPig+cR0HdQq4P=MWg7xkFLMzNimitty_Bj7mVx+w3eoi9bZ3g@mail.gmail.com' \
    --to=sunshine@sunshineco.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j6t@kdbg.org \
    --cc=ramsay@ramsay1.demon.co.uk \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).