[PATCH] gitrepository-layout: No longer first two letters. Also add "down".

[PATCH] gitrepository-layout: No longer first two letters. Also add "down".

[jidanni]

Signed-off-by: jidanni <jidanni@jidanni.org>

diff --git a/gitrepository-layout.txt b/gitrepository-layout.txt
index 03c52ff..81103fc 100644
--- a/gitrepository-layout.txt
+++ b/gitrepository-layout.txt
@@ -46,6 +46,4 @@ objects/[0-9a-f][0-9a-f]::
-	Traditionally, each object is stored in its own file.
-	They are split into 256 subdirectories using the first
-	two letters from its object name to keep the number of
-	directory entries `objects` directory itself needs to
-	hold.  Objects found here are often called 'unpacked'
-	(or 'loose') objects.
+	Traditionally, each object is stored in its own file. They are
+	split into 256 subdirectories to keep the number of directory
+	entries `objects` directory itself needs to hold down. Objects
+	found here are often called 'unpacked' (or 'loose') objects.
-- 
1.5.6.5

Re: [PATCH] gitrepository-layout: No longer first two letters. Also add "down".

[Junio C Hamano]

jidanni@jidanni.org writes:

> Signed-off-by: jidanni <jidanni@jidanni.org>

First off, when I tried to respond to your message, I got this:

    Cc: undisclosed-recipients:;

which I had to edit it to point at the list.

I think you did "Bcc: git@vger.kernel.org" without any explicit recipient;
please don't.  It wastes everybody's time.

Second, please realize that the Subject: line is one of the most important
piece of information in your patch submission.  It is used as the summary
of what this change is about in the shortlog output.  2 months from now,
do you think anybody (other than you) can guess what the "first two
letters" is about among 400 other changes?

I would have preferred the Subject: and the commit log message like this
for this patch:

    Subject: [PATCH] Fix description of objects/??/ directories in the repository-layout doc

    These fan-out directories are no longer first two letters.  Also fix
    a sentence that meant to say "keep something down" but forgot "down".

That is, summarize what this patch is about on Subject: line, and explain
why the change is a good idea (in other words, why the current one is bad)
in the commit log message.

I agree with the "down" fix; thanks for catching this grammatical and
semantic error.

I however do not understand the reason behind the former "two letters"
change.

When creating a new object, the filename to hold it when its object name
is e.g. 92b35d66d0e335771c2e4a4a79f95adb844b1f91 (that's a tag object for
v1.6.1 if anybody cares) is computed by taking its first two letters "92"
and using that to choose ".git/object/92" as the containing "fan-out"
directory.  The file in that directory is named using the remainder of the
object name.

The entry in the repository layout document explains what the directories
with two-letter names you find in objects/ directory are, and I do not see
a reason why you want to say "no longer first two letters".  Their names
still are, and very likely continue to be, two-letter long.

Maybe I misunderstood what you wanted to say by "no longer...".  Did you
mean (unlike the sample commit log message I suggested above):

    Subject: [PATCH] Fix description of objects/??/ directories in the repository-layout doc

    Do not say first two letters anymore.  Also fix a sentence that meant
    to say "keep something down" but forgot "down".

If that is the case, please justify why you think it is better not to say
"first two letters" the documentation.

Thanks.

Re: [PATCH] gitrepository-layout: No longer first two letters. Also add "down".

[jidanni]

>>>>> "JCH" == Junio C Hamano <gitster@pobox.com> writes:

JCH> If that is the case, please justify why you think it is better not to say
JCH> "first two letters" the documentation.
OK, I saw
$ ls 3d
05a66c3..
189066f..
If it were the first to letters, it would be
$ ls 3d
3d05a66c3..
3d189066f..
Ah, you mean it snaps them off to form the directory name?! OK, please
note that.

As far as all your other points and messed up To:, OK, next time I will do better.

Re: [PATCH] gitrepository-layout: No longer first two letters. Also add "down".

[Junio C Hamano]

jidanni@jidanni.org writes:

>>>>>> "JCH" == Junio C Hamano <gitster@pobox.com> writes:
>
> JCH> If that is the case, please justify why you think it is better not to say
> JCH> "first two letters" the documentation.
> OK, I saw
> $ ls 3d
> 05a66c3..
> 189066f..
> If it were the first to letters, it would be
> $ ls 3d
> 3d05a66c3..
> 3d189066f..
> Ah, you mean it snaps them off to form the directory name?! OK, please
> note that.

If you read the description again, you will notice that the entry explains
what these directories are; it is not a description about the files in
these directories.

> As far as all your other points and messed up To:, OK, next time I will do better.

When sending the fixed-up patch, please send it in an applicable form.  I
do not know how you stripped "Documentation/" from the front, but your
patch was against {a,b}/gitrepository-layout.txt.

Thanks.

Re: [PATCH] gitrepository-layout: No longer first two letters. Also add "down".

[Nanako Shiraishi]

Quoting jidanni@jidanni.org:

> Signed-off-by: jidanni <jidanni@jidanni.org>

Didn't you mean "Signed-off-by: 積丹尼 <jidanni@jidanni.org>"?

-- 
Nanako Shiraishi
http://ivory.ap.teacup.com/nanako3/

commit.template

[jidanni]

NS> Didn't you mean "Signed-off-by: 積丹尼 <jidanni@jidanni.org>"?

No. I want in fact just to use "Signed-off-by: jidanni@jidanni.org",
but apparently
1) man git-config mentions
       commit.template
           Specify a file to use as the template for new commit messages.

but doesn't mention what file is being used presently, so one can know
what to adjust.

2) .git/hooks/commit-msg etc. don't seem to control that line.
3) Making a line without a name would probably break other things.

Re: [PATCH] gitrepository-layout: No longer first two letters. Also add "down".

[jidanni]

OK, the two letters are related by an algorithm.

Re: commit.template

[Junio C Hamano]

jidanni@jidanni.org writes:

> NS> Didn't you mean "Signed-off-by: 積丹尼 <jidanni@jidanni.org>"?
>
> No. I want in fact just to use "Signed-off-by: jidanni@jidanni.org",

That won't fly well, provided if you want your patches in git.git tree.

Re: commit.template

[Boyd Stephen Smith Jr.]

[-- Attachment #1: Type: text/plain, Size: 930 bytes --]

On Friday 2008 December 26 16:42:09 jidanni@jidanni.org wrote:
> NS> Didn't you mean "Signed-off-by: 積丹尼 <jidanni@jidanni.org>"?
>
> No. I want in fact just to use "Signed-off-by: jidanni@jidanni.org",
> but apparently
> 1) man git-config mentions
>        commit.template
>            Specify a file to use as the template for new commit messages.
>
> but doesn't mention what file is being used presently, so one can know
> what to adjust.

git commit --help tells how this configuration option is used, in the 
documentation of the "-t" option.

> 3) Making a line without a name would probably break other things.

Well, then use your legal name -- unicode is allowed.
-- 
Boyd Stephen Smith Jr.                     ,= ,-_-. =. 
bss@iguanasuicide.net                     ((_/)o o(\_))
ICQ: 514984 YM/AIM: DaTwinkDaddy           `-'(. .)`-' 
http://iguanasuicide.net/                      \_/     

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: commit.template

[jidanni]

OK, both
>> 1) man git-config mentions
>> commit.template
and
BSS> git commit --help tells how this configuration option is used, in the 
BSS> documentation of the "-t" option.
should
>> mention what file is being used presently
as one needs a template in order to modify a template... in case
someone one day wants to. Not me. I'm happy already.

Re: commit.template

[Nanako Shiraishi]

Quoting jidanni@jidanni.org:

> NS> Didn't you mean "Signed-off-by: 積丹尼 <jidanni@jidanni.org>"?
>
> No. I want in fact just to use "Signed-off-by: jidanni@jidanni.org",

I think everybody on the list now understands that you desperately want to be different.  I think it would be beneficial for you to try making a difference in areas that matter, instead of just trying to be different in how your name is spelled.

Just my two yen ;-)

-- 
Nanako Shiraishi
http://ivory.ap.teacup.com/nanako3/

Re: commit.template

[Junio C Hamano]

Nanako Shiraishi <nanako3@lavabit.com> writes:

> Quoting jidanni@jidanni.org:
>
>> NS> Didn't you mean "Signed-off-by: 積丹尼 <jidanni@jidanni.org>"?
>>
>> No. I want in fact just to use "Signed-off-by: jidanni@jidanni.org",
>
> I think everybody on the list now understands that you desperately want to be different.  I think it would be beneficial for you to try making a difference in areas that matter, instead of just trying to be different in how your name is spelled.
>
> Just my two yen ;-)

Even though I soft-of-kind-of understand that you are frustrated for
getting that response after offering an advice to satisfy his earlier
wish:

	"Thanks but I want to be http://zh.wikipedia.org/wiki/積丹尼"

made in $gmane/103591, you do not sound so harsh and play a bad girl.

Be civil and friendly around here, please...

Re: commit.template

[Junio C Hamano]

Junio C Hamano <gitster@pobox.com> writes:

> made in $gmane/103591, you do not sound so harsh and play a bad girl.

Sorry, I meant "do not have to"...

Re: commit.template

[Boyd Stephen Smith Jr.]

[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]

On Friday 2008 December 26 18:01:18 jidanni@jidanni.org wrote:
> OK, both
>
> >> 1) man git-config mentions
> >> commit.template
>
> and
> BSS> git commit --help tells how this configuration option is used, in the
> BSS> documentation of the "-t" option.
> should
>
> >> mention what file is being used presently

There is no file being used presently.  With the "-m" or "-F" option, no 
template is ever used.  Without those options, either the argument to "-t" or 
the value of commit.template is used in that order; the editor is invoked on 
that.  Finally if neither of those are defined the editor is invoked on a 
new, empty file.

> as one needs a template in order to modify a template.

You aren't modifying the template with commit.template or "-t", you are 
specifying one.  You can create one from scratch in your editor of choice.
-- 
Boyd Stephen Smith Jr.                     ,= ,-_-. =. 
bss@iguanasuicide.net                     ((_/)o o(\_))
ICQ: 514984 YM/AIM: DaTwinkDaddy           `-'(. .)`-' 
http://iguanasuicide.net/                      \_/     

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: commit.template

[jidanni]

OK, but there should be a reference to any %escapes available in
templates, etc.

Or say the template is purely and additional ".signature" style file
that will be inserted at some certain spot...

Re: commit.template

[Boyd Stephen Smith Jr.]

[-- Attachment #1: Type: text/plain, Size: 934 bytes --]

On Friday 2008 December 26 19:04:06 jidanni@jidanni.org wrote:
> OK, but there should be a reference to any %escapes available in
> templates, etc.

There are none, at least not right now.

> Or say the template is purely and additional ".signature" style file
> that will be inserted at some certain spot...

There's what it says:
"Use the contents of the given file as the initial version of the
commit message. The editor is invoked and you can make subsequent
changes. [...] This overrides the commit.template
configuration variable."
	-- 'git commit --help'

What isn't clear about that?  It's not an *extra* file; it is the template 
(what you start with) for commit messages.
-- 
Boyd Stephen Smith Jr.                     ,= ,-_-. =. 
bss@iguanasuicide.net                     ((_/)o o(\_))
ICQ: 514984 YM/AIM: DaTwinkDaddy           `-'(. .)`-' 
http://iguanasuicide.net/                      \_/     

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: commit.template

[jidanni]

I see, it's not replacing something current. It is adding something
extra. OK, would have never guessed. OK, stopping here.

Re: [PATCH] gitrepository-layout: No longer first two letters. Also add "down".

[Sverre Rabbelier]

On Fri, Dec 26, 2008 at 16:02, Nanako Shiraishi <nanako3@lavabit.com> wrote:
> Quoting jidanni@jidanni.org:
>
>> Signed-off-by: jidanni <jidanni@jidanni.org>
>
> Didn't you mean "Signed-off-by: 積丹尼 <jidanni@jidanni.org>"?

Be nice, they are obviously a bit peculiar about their name/sign-off name :).
-- 
Cheers,

Sverre Rabbelier

Re: [PATCH] gitrepository-layout: No longer first two letters. Also add "down".

[Nanako Shiraishi]

Quoting "Sverre Rabbelier" <srabbelier@gmail.com>:

> On Fri, Dec 26, 2008 at 16:02, Nanako Shiraishi <nanako3@lavabit.com> wrote:
>> Quoting jidanni@jidanni.org:
>>
>>> Signed-off-by: jidanni <jidanni@jidanni.org>
>>
>> Didn't you mean "Signed-off-by: 積丹尼 <jidanni@jidanni.org>"?
>
> Be nice, they are obviously a bit peculiar about their name/sign-off name :).

If you are telling me that I said something un-nice, I apologize. I did not mean to offend anybody. But I do not understand.  Who do you mean by they in your sentence?  

> -- 
> Cheers,
>
> Sverre Rabbelier
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Nanako Shiraishi
http://ivory.ap.teacup.com/nanako3/