git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hannu Koivisto <azure@iki.fi>
To: git@vger.kernel.org
Subject: Re: git bisect view's use of DISPLAY environment variable in Cygwin
Date: Wed, 29 Oct 2008 01:26:19 +0200	[thread overview]
Message-ID: <83ej20cndw.fsf@kalahari.s2.org> (raw)
In-Reply-To: 83iqrccpmk.fsf@kalahari.s2.org

Hannu Koivisto <azure@iki.fi> writes:

> "Christian Couder" <christian.couder@gmail.com> writes:
>
>> On Tue, Oct 28, 2008 at 6:51 PM, Hannu Koivisto <azure@iki.fi> wrote:
>>> "Christian Couder" <christian.couder@gmail.com> writes:
>
>> We need at least a way to detect we are under Cygwin, because we won't
>> change the current behavior for all platforms.
>> Is checking for the CYGWIN environment variable enough?
>
> No, because it may not be set.  I would probably do it at compile
> time using __CYGWIN__ definition.  I don't know what's the status

Argh, I didn't realize git-bisect is a shell script.  For detecting
Cygwin in shell scripts I have tested if `uname` matches CYGWIN*.
For detecting Windows I have tested if PROCESSOR_ARCHITECTURE is
set.  There may well be better ways.

-- 
Hannu

  reply	other threads:[~2008-10-28 23:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-28 16:28 git bisect view's use of DISPLAY environment variable in Cygwin Hannu Koivisto
2008-10-28 17:15 ` Christian Couder
2008-10-28 17:51   ` Hannu Koivisto
2008-10-28 19:13     ` Christian Couder
2008-10-28 22:37       ` Hannu Koivisto
2008-10-28 23:26         ` Hannu Koivisto [this message]
2008-10-29  0:46           ` Johannes Schindelin
2008-10-29 13:31             ` Hannu Koivisto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ej20cndw.fsf@kalahari.s2.org \
    --to=azure@iki.fi \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).