From: "Christian Couder" <christian.couder@gmail.com>
To: "Hannu Koivisto" <azure@iki.fi>
Cc: git@vger.kernel.org
Subject: Re: git bisect view's use of DISPLAY environment variable in Cygwin
Date: Tue, 28 Oct 2008 20:13:48 +0100 [thread overview]
Message-ID: <c07716ae0810281213k432d82d8i468f54ae03146b88@mail.gmail.com> (raw)
In-Reply-To: <83skqg1uc9.fsf@kalahari.s2.org>
On Tue, Oct 28, 2008 at 6:51 PM, Hannu Koivisto <azure@iki.fi> wrote:
> "Christian Couder" <christian.couder@gmail.com> writes:
>
>> Hi,
>>
>> On Tue, Oct 28, 2008 at 5:28 PM, Hannu Koivisto <azure@iki.fi> wrote:
>>> Greetings,
>>>
>>> git bisect view uses gitk if DISPLAY environment variable is set
>>> and git log otherwise. Since gitk doesn't require X server in
>>> Cygwin, that seems like a bit questionable condition in that
>>> environment.
>>
>> Do you know any environment variable that we could use to detect we
>> can use gitk in Cygwin?
>
> I looked around and I believe there is no such variable. I suppose
> the only case where you cannot use gitk is when the user is logged
> on using ssh, telnet, psexec or similar (well, unless you use some
> non-standard Tcl/Tk build which is configured to use X instead of
> Windows graphics). Then again, I don't think typical Windows
> programs do any checks for such situations.
We need at least a way to detect we are under Cygwin, because we won't
change the current behavior for all platforms.
Is checking for the CYGWIN environment variable enough?
> So, easy fix: always use gitk unless log is specified. Harder fix:
> figure out a way to test if the login session is such that
> graphical applications can be run.
>
>> You can use "git bisect view log" to use "git log" even if DISPLAY is set.
>
> I'd rather not use undocumented functionality ;)
In this case you can use any "git log" option after "git bisect view"
(for example: git bisect view -p).
Regards,
Christian.
next prev parent reply other threads:[~2008-10-28 20:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-28 16:28 git bisect view's use of DISPLAY environment variable in Cygwin Hannu Koivisto
2008-10-28 17:15 ` Christian Couder
2008-10-28 17:51 ` Hannu Koivisto
2008-10-28 19:13 ` Christian Couder [this message]
2008-10-28 22:37 ` Hannu Koivisto
2008-10-28 23:26 ` Hannu Koivisto
2008-10-29 0:46 ` Johannes Schindelin
2008-10-29 13:31 ` Hannu Koivisto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c07716ae0810281213k432d82d8i468f54ae03146b88@mail.gmail.com \
--to=christian.couder@gmail.com \
--cc=azure@iki.fi \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).